Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Drop COOKIE auth support #727

Closed
zeenix opened this issue Apr 18, 2024 · 2 comments
Closed

RFC: Drop COOKIE auth support #727

zeenix opened this issue Apr 18, 2024 · 2 comments
Labels
api break zbus Issues/PRs related to zbus crate
Milestone

Comments

@zeenix
Copy link
Contributor

zeenix commented Apr 18, 2024

COOKIE auth is not needed at all on Unix platforms, has a complicated implementation (especially the server side) and drags in sha1 dep (see #530). The only real use case I see for it is Windows, where we currently don't support EXTERNAL auth but once that's fixed (#723), we could think about this.

There is also the use case of TCP but I'm not sure, that's worth keeping either. If UDS is available on all platforms (that we care about), there is no good reason to use TCP. For remote use case, TCP should be highly discouraged since it's unencrypted and COOKIE auth won't work for that anyway.

Together with we can #726, we can really simplify the auth code and pipeline the client-side handshake better (making it go much faster).

@zeenix zeenix added api break zbus Issues/PRs related to zbus crate labels Apr 18, 2024
@zeenix
Copy link
Contributor Author

zeenix commented Apr 24, 2024

Dropping the idea in favor of #731.

@zeenix zeenix closed this as completed Apr 24, 2024
@zeenix
Copy link
Contributor Author

zeenix commented Oct 3, 2024

I'm rethinking this. @elmarco do you think it'd be a big deal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api break zbus Issues/PRs related to zbus crate
Projects
None yet
Development

No branches or pull requests

1 participant