💥 zb: Drop support for DBUS_COOKIE_SHA1 auth mechanism
#1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It drags the `sha1` crate as a dependency, which can be [problematic for some users]. * It makes the handshake more complex, not allowing to pipeline all the commands. * It's not widely used. If `EXTERNAL` is not an option, you might as well just use `ANONYMOUS`. Fixes dbus2#727. [problematic for some users]: dbus2#543
This was only needed for `DBUS_COOKIE_SHA1` auth mechansim, which was just dropped so we can happily drop this. Fixes dbus2#543.
Since we just dropped the support for it.
zeenix
added a commit
to zeenix/busd
that referenced
this pull request
Oct 3, 2024
This is in preparation for zbus dropping it in 5.0: dbus2/zbus#1039 Besides, I added this support mainly for hopes of possibly using it for a remote transport. However, due to lack of time and funding, I decided to drop those plans from the roadmap.
|
@zeenix When is the next release which has SHA1 dependency removed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sha1crate as a dependency, which can be problematic for some users.EXTERNALis not an option, you might as well just useANONYMOUS.Fixes #543, #727.