Don't split prompt and question in CredentialManager #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In opposition to the `Credential`'s in datalad core, the CredentialManager splits the prompting text and the input retrieval when asking for a property or secret by calling `ui.message` and then `ui.question`. While this is kinda fine with CLI, other `ui` backends like gooey can't handle this properly (leading to datalad/datalad-gooey#340). The `title` parameter of `ui.question` is intended for the prompting text, which is somewhat misleading by name.
Codecov ReportBase: 94.41% // Head: 91.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 94.41% 91.09% -3.33%
==========================================
Files 38 38
Lines 3956 4232 +276
==========================================
+ Hits 3735 3855 +120
- Misses 221 377 +156
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
titleparameter ofui.questionis intended for the prompting text, which is somewhat misleading by name.In opposition to the
Credential's in datalad core, the CredentialManager splits the prompting text and the input retrieval when asking for a property or secret by callingui.messageand thenui.question. While this is kinda fine with CLI, otheruibackends like gooey can't handle this properly. In combination with patchingcreate-sibling-ghlikethis led to datalad/datalad-gooey#340.