Merge pull request #113 from bpoldrack/fix-credman

Don't split prompt and question in CredentialManager
datalad · Oct 14, 2022 · c4302a6 · c4302a6
2 parents 9e14273 + 256d2fa
commit c4302a6
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/datalad_next/credman.py b/datalad_next/credman.py
@@ -510,17 +510,17 @@ def _ask_property(self, name, prompt=None):
         if not ui.is_interactive:
             lgr.debug('Cannot ask for credential property %r in non-interactive session', name)
             return
-        self._prompt(prompt)
-        return ui.question(name, title=None)
+
+        return ui.question(name, title=prompt)
 
     def _ask_secret(self, type_hint=None, prompt=None):
         if not ui.is_interactive:
             lgr.debug('Cannot ask for credential secret in non-interactive session')
             return
-        self._prompt(prompt)
+
         return ui.question(
             type_hint or 'secret',
-            title=None,
+            title=prompt,
             repeat=self._cfg.obtain(
                 'datalad.credentials.repeat-secret-entry'),
             hidden=self._cfg.obtain(