Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't split prompt and question in CredentialManager #113

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Don't split prompt and question in CredentialManager #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions datalad_next/credman.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,17 +510,17 @@ def _ask_property(self, name, prompt=None):
if not ui.is_interactive:
lgr.debug('Cannot ask for credential property %r in non-interactive session', name)
return
self._prompt(prompt)
return ui.question(name, title=None)

return ui.question(name, title=prompt)

def _ask_secret(self, type_hint=None, prompt=None):
if not ui.is_interactive:
lgr.debug('Cannot ask for credential secret in non-interactive session')
return
self._prompt(prompt)

return ui.question(
type_hint or 'secret',
title=None,
title=prompt,
repeat=self._cfg.obtain(
'datalad.credentials.repeat-secret-entry'),
hidden=self._cfg.obtain(
Expand Down