Fix ui.question's text + title #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalad core's ui.question is meant to take the prompting text via `title`. Now that there's a GUI backend this turns out to be a misleading name. Fix the implementation to use the passed `title` in the label and have constant window title instead.
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datalad core's
ui.questionis meant to take the prompting text viatitle. Now that there's a GUI backend this turns out to be a misleading name.Fix the implementation to use the passed
titlein the label and have constant window title instead.Not sure about that constant title, though.
Input requiredmay feel somewhat strange. Happy for other suggestions.In combination with datalad/datalad-next#113 this is supposed to fix #340 .