Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on nightly-2024-02-05 #618

Closed
leighmcculloch opened this issue Feb 6, 2024 · 2 comments · Fixed by #621
Closed

Build fails on nightly-2024-02-05 #618

leighmcculloch opened this issue Feb 6, 2024 · 2 comments · Fixed by #621

Comments

@leighmcculloch
Copy link

Builds using curve25519-dalek started to fail on nightly-2024-02-05. These builds passed on nightly-2024-02-03.

Here's an extract of the build error, from a GitHub Actions CI run where the full build is captured here.

error[E0658]: use of unstable library feature 'stdarch_x86_avx512'
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.1/src/backend/vector/ifma/field.rs:26:5
   |
26 |     _mm256_madd52lo_epu64(z.into(), x.into(), y.into()).into()
   |     ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111137 <https://github.com/rust-lang/rust/issues/111137> for more information
   = help: add `#![feature(stdarch_x86_avx512)]` to the crate attributes to enable
   = note: this compiler was built on 2024-02-05; consider upgrading it if it is out of date

error[E0658]: use of unstable library feature 'stdarch_x86_avx512'
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.1/src/backend/vector/ifma/field.rs:25:9
   |
25 |     use core::arch::x86_64::_mm256_madd52lo_epu64;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111137 <https://github.com/rust-lang/rust/issues/111137> for more information
   = help: add `#![feature(stdarch_x86_avx512)]` to the crate attributes to enable
   = note: this compiler was built on 2024-02-05; consider upgrading it if it is out of date

error[E0658]: use of unstable library feature 'stdarch_x86_avx512'
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.1/src/backend/vector/ifma/field.rs:34:5
   |
34 |     _mm256_madd52hi_epu64(z.into(), x.into(), y.into()).into()
   |     ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111137 <https://github.com/rust-lang/rust/issues/111137> for more information
   = help: add `#![feature(stdarch_x86_avx512)]` to the crate attributes to enable
   = note: this compiler was built on 2024-02-05; consider upgrading it if it is out of date

error[E0658]: use of unstable library feature 'stdarch_x86_avx512'
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.1/src/backend/vector/ifma/field.rs:33:9
   |
33 |     use core::arch::x86_64::_mm256_madd52hi_epu64;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111137 <https://github.com/rust-lang/rust/issues/111137> for more information
   = help: add `#![feature(stdarch_x86_avx512)]` to the crate attributes to enable
   = note: this compiler was built on 2024-02-05; consider upgrading it if it is out of date

error[E0635]: unknown feature `stdsimd`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.1/src/lib.rs:13:70
   |
13 | #![cfg_attr(all(curve25519_dalek_backend = "simd", nightly), feature(stdsimd))]
   |                                                                      ^^^^^^^

Some errors have detailed explanations: E0635, E0658.
For more information about an error, try `rustc --explain E0635`.
error: could not compile `curve25519-dalek` (lib) due to 5 previous errors
@i18nsite
Copy link

i18nsite commented Feb 6, 2024

same error on mac x86

@jimmygchen
Copy link
Contributor

I've submitted a PR to fix this: #619

ChengyuZhu6 added a commit to ChengyuZhu6/guest-components that referenced this issue Feb 6, 2024
Rustc 1.78.0-nightly (f067fd608 2024-02-05) was the latest nightly release, but it has a compatibility issue with
curve25519-dalek dalek-cryptography/curve25519-dalek#618.
So we bump the version of rust nightly to nightly-2024-02-03.

Signed-off-by: ChengyuZhu6 <[email protected]>
Billy99 added a commit to Billy99/bpfman that referenced this issue Feb 6, 2024
Pin rust to nightly-2024-02-03 until
dalek-cryptography/curve25519-dalek#618
is fixed.

Signed-off-by: Billy McFall <[email protected]>
AaronFeickert added a commit to tari-project/triptych that referenced this issue Feb 6, 2024
An [issue](dalek-cryptography/curve25519-dalek#618) with the curve library means nightly compilers after `nightly-2024-02-04` will not work. The documentation currently references the latest nightly compiler for benchmarks and fuzzing; this PR adds a warning and updates the relevant commands.
hko-s added a commit to hko-s/rpgp that referenced this issue Feb 6, 2024
Billy99 added a commit to Billy99/bpfman that referenced this issue Feb 6, 2024
Pin rust to nightly-2024-02-03 until
dalek-cryptography/curve25519-dalek#618
is fixed.

Signed-off-by: Billy McFall <[email protected]>
Billy99 added a commit to Billy99/bpfman that referenced this issue Feb 6, 2024
Pin rust to nightly-2024-02-03 until
dalek-cryptography/curve25519-dalek#618
is fixed.

Signed-off-by: Billy McFall <[email protected]>
astoycos pushed a commit to bpfman/bpfman that referenced this issue Feb 6, 2024
Pin rust to nightly-2024-02-03 until
dalek-cryptography/curve25519-dalek#618
is fixed.

Signed-off-by: Billy McFall <[email protected]>
@rozbb rozbb closed this as completed in #621 Feb 7, 2024
ChengyuZhu6 added a commit to ChengyuZhu6/guest-components that referenced this issue Feb 7, 2024
Rustc 1.78.0-nightly (f067fd608 2024-02-05) was the latest nightly release, but it has a compatibility issue with
curve25519-dalek dalek-cryptography/curve25519-dalek#618.

Now curve25519-dalek and x25519-dalek have a new release to fix the
issue. So we can update the dependencies about curve25519-dalek and
x25519-dalek.

Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6 added a commit to ChengyuZhu6/guest-components that referenced this issue Feb 7, 2024
Rustc 1.78.0-nightly (f067fd608 2024-02-05) was the latest nightly release, but it has a compatibility issue with
curve25519-dalek dalek-cryptography/curve25519-dalek#618.

Now curve25519-dalek and x25519-dalek have a new release to fix the
issue. So we can update the dependencies about curve25519-dalek and
x25519-dalek.

Signed-off-by: ChengyuZhu6 <[email protected]>
Xynnn007 pushed a commit to confidential-containers/guest-components that referenced this issue Feb 7, 2024
Rustc 1.78.0-nightly (f067fd608 2024-02-05) was the latest nightly release, but it has a compatibility issue with
curve25519-dalek dalek-cryptography/curve25519-dalek#618.

Now curve25519-dalek and x25519-dalek have a new release to fix the
issue. So we can update the dependencies about curve25519-dalek and
x25519-dalek.

Signed-off-by: ChengyuZhu6 <[email protected]>
SWvheerden pushed a commit to tari-project/tari-crypto that referenced this issue Feb 7, 2024
Sadly, nightly CI is borked due to an [upstream
issue](dalek-cryptography/curve25519-dalek#618)
identified with a recent nightly release.

This PR pins the nightly toolchain at a working version.
SWvheerden pushed a commit to tari-project/bulletproofs-plus that referenced this issue Feb 7, 2024
This PR flips the script on #92 and pins the nightly toolchain. This is
necessary due to an [upstream
issue](dalek-cryptography/curve25519-dalek#618)
that now fails nightly CI.
alepez added a commit to alepez/lavagna that referenced this issue Feb 8, 2024
Fix failing build on nightly-2024-02-05.
See dalek-cryptography/curve25519-dalek#618
Eugeny pushed a commit to Eugeny/russh that referenced this issue Apr 22, 2024
Due to [this
issue](dalek-cryptography/curve25519-dalek#618)
the current version of `russh` does not compile on the current nightly
compiler. I have updated the dependency for curve25519-dalek to `4.1.2`
which solves the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants