Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nightly builds fail due to curve25519-dalek #575

Closed
saman3d opened this issue May 13, 2024 · 4 comments
Closed

nightly builds fail due to curve25519-dalek #575

saman3d opened this issue May 13, 2024 · 4 comments

Comments

@saman3d
Copy link

saman3d commented May 13, 2024

due to this issue Build fails on nightly-2024-02-05 dalek builds started to fail on nightly 2024-02-05.

they released a new patch version fixing this issue.
pr: Fix nightly build
tag: 4.1.2

please update curve25519-dalek dependency version

@saman3d
Copy link
Author

saman3d commented May 15, 2024

I need to build my project with the new rust nightly version. can I open a pr for this issue?

@jrose-signal
Copy link
Contributor

We're discussing what to do about 4.1.2 not passing its own CI tests on nightly (because new warnings have been introduced). Upstream has fixes for that as well, but they're not in an actual tag yet.

Note that you don't need to use Signal's fork of curve25519-dalek unless you're using zkgroup. The other crates can use the normal upstream version.

@jrose-signal
Copy link
Contributor

(Update: we asked the dalek folks for a new tag, they haven't committed to one yet.)

@jrose-signal
Copy link
Contributor

Included in v0.51.1, using curve25519-dalek v4.1.3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants