Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish profile avatar URL #290

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Publish profile avatar URL #290

merged 1 commit into from
Feb 14, 2024

Conversation

Schmiddiii
Copy link
Contributor

This is to allow presage to fetch profile avatars.

This is to allow presage to fetch profile avatars.
@Schmiddiii
Copy link
Contributor Author

(CI failure is most likely not my fault, something nightly-related)

@rubdos
Copy link
Member

rubdos commented Feb 13, 2024

Hmm, how comes Whisperfish could show profiles? Am I using some API that I should not? :D

@Schmiddiii
Copy link
Contributor Author

Hmm, how comes Whisperfish could show profiles? Am I using some API that I should not? :D

You are directly using SignalServiceProfile, which I did not want to use with presage as this seems pretty low-level and also contains encrypted data.

(CI failure is most likely not my fault, something nightly-related)

This seems to be dalek-cryptography/curve25519-dalek#618. Not sure what we can do about that as libsignal depends on its own version of curve25519-dalek and this does not yet have version 4.1.2 available, which would fix this.

@rubdos
Copy link
Member

rubdos commented Feb 14, 2024

(CI failure is most likely not my fault, something nightly-related)

This seems to be dalek-cryptography/curve25519-dalek#618. Not sure what we can do about that as libsignal depends on its own version of curve25519-dalek and this does not yet have version 4.1.2 available, which would fix this.

Looks like that will be fixed automagically anyway, so this sounds mergable to me.

@rubdos rubdos merged commit 3b51a6f into whisperfish:main Feb 14, 2024
15 of 18 checks passed
@Schmiddiii Schmiddiii deleted the avatar branch February 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants