Update our lock file and Rust nightly version #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dalek crates got a new release fixing some build issues on nightly. This should get rid of those build issues.
jmartinesp
approved these changes
Feb 7, 2024
But not on the CI 🥲. I think we'll need to bump our nightly version as well. |
|
We'll pin our nightly version in the CI to match yours. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3103 +/- ##
==========================================
- Coverage 83.71% 83.70% -0.01%
==========================================
Files 224 224
Lines 23534 23535 +1
==========================================
Hits 19701 19701
- Misses 3833 3834 +1 ☔ View full report in Codecov by Sentry. |
The IndexMap::remove method has been deprecated, the documentation[1] on the method tells us that we can replace the usage of it with IndexMap::swap_remove: > NOTE: This is equivalent to .swap_remove(key), replacing this entry’s > position with the last element, and it is deprecated in favor of > calling that explicitly. [1]: https://docs.rs/indexmap/2.2.2/indexmap/map/struct.IndexMap.html#method.remove
Hywan
approved these changes
Feb 7, 2024
poljar
changed the title
The linking error[1] on Mac still isn't fixed. [1]: seanmonstar/reqwest#2006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dalek crates got a new release fixing some build issues on nightly. This should get rid of those build issues.
Link to the relevant issue: dalek-cryptography/curve25519-dalek#618.