fix(authproxy): set openshift oauth proxy prefix to match oauth2_proxy prefix #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cryostatio/cryostat#365
Depends on cryostatio/cryostat#366
It's a bit of a long incantation for testing this, but it's because OpenShift auth must be enabled, I also enable basic auth to test that second case, and then until cryostatio/cryostat#366 is merged it must be tested with a custom Cryostat image, and it must also be tested with a custom oauth-proxy image until openshift/oauth-proxy#272 is addressed.
After that, you should be able to open the Cryostat UI. You will first be greeted by the openshift-oauth-proxy login screen. Log in via htpasswd with
user:pass
. You should see the actual Cryostat UI. Click the user icon and Logout in the masthead. You should be returned to the login screen - refreshing the page should leave you on the login screen. Next try logging in with OpenShift SSO. This should work largely the same way, but use your OpenShift account credentials instead ofuser:pass
.Odd bug: if you don't also enable the htpasswd Basic auth mechanism and leave it on OpenShift SSO only, then the logout does not fully work due to a CORS issue.However after pressing the Logout button all UI requests fail (because you are actually logged out), and if you try to refresh the page then you will land on the OpenShift SSO login agin.See cryostatio/cryostat-web#1237 for the bugfix.