fix(oauth): enable signout redirect #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
andrewazores
force-pushed
the
oauth-signout
branch
from
d329791 to
ef123db
Compare
|
This PR/issue depends on: |
|
/build_test |
|
Workflow started at 4/12/2024, 3:44:06 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
mwangggg
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #365
Depends on cryostatio/cryostat-web#1236
Description of the change:
When clicking the "logout" button in the application masthead, the web-client sends a request to the Cryostat server at
/api/v2.1/logout. The current implementation just treats this as a no-op and returns HTTP 204. This new implementation responds with a redirect instructing the client to go to/oauth2/sign_out, which triggers the logout flow of the auth proxy.Motivation for the change:
Re-enables the ability for the user to log out.
How to manually test:
./mvnw clean package ; podman image prune -f ; ./smoketest.bash -Ouser:pass, go to UI. Then click user icon and "logout" on the masthead. You should be returned back to the authproxy login screen. If you refresh here you should still be on the login screen (not re-entered into the Cryostat UI).