Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oauth): remove unused openshift-specific logout function #1236

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 12, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat#365

Description of the change:

Removes unused code that was left in "just in case". In cryostatio/cryostat#366 and cryostatio/cryostat-helm#131 I have determined that it really is not needed anymore due to the new authproxy architecture.

@mergify mergify bot added the safe-to-test label Apr 12, 2024
@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Apr 12, 2024
@andrewazores andrewazores merged commit a9c3d73 into cryostatio:main Apr 12, 2024
24 of 26 checks passed
@andrewazores andrewazores deleted the oauth-signout branch April 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants