Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): force reload to / on any logout result #1237

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 15, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


See cryostatio/cryostat-helm#131 (comment)

Description of the change:

Force reload to application root path on any signout response, success or failure or error.

How to manually test:

  1. See fix(authproxy): set openshift oauth proxy prefix to match oauth2_proxy prefix cryostat-helm#131 (comment) for the k8s/OpenShift case, or use cryostat3 smoketest for a simple oauth2 proxy case
  2. Build an image including this PR, or use the image quay.io/andrewazores/cryostat:3.0.0-logout-refresh-1
  3. Test logging in and then logging out. In all cases (OAuth2 proxy with htpasswd Basic, openshift-oauth-proxy with only OpenShift SSO, or openshift-oauth-proxy with OpenShift SSO + htpasswd Basic), logging out from the UI should kick the browser back out to the auth proxy sign in page. Refreshing from here or reopening the URL in a new tab/window should still result in the sign in page (session has been cleared). Logging back in again should work as expected.

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit c93e6b4 into cryostatio:main Apr 15, 2024
25 of 26 checks passed
@andrewazores andrewazores deleted the oauth-signout-refresh branch April 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants