-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the slippage tolerance in the settings of the user when we submit the order #332
Comments
Bringing back the comment from our sprint session: Coordinate with backend, the initial Idea:
Depend on cowprotocol/services#131 |
Adding some document to help with the definition and coordination https://docs.google.com/document/d/1N8K-ueKxxuuFfKjnegbPUYx30Qk1H8zjeiLo3jg-X14/edit# |
Nick created a task for the quoteId cowprotocol/services#170 |
Implementation details (based on the gdoc shared above) CowSwap:
(1) Need to merge with any potential affiliate link data present. Will likely require a re-work on that flow, though (2) Requires a model change and probably version bump on metadata doc definition:
|
We want to pass the slippage tolerance value as an order parameter to the API's and/or also to the Sentry.
The text was updated successfully, but these errors were encountered: