Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Include the slippage tolerance in the settings of the user when we submit the order #2617

Open
nenadV91 opened this issue Mar 31, 2022 · 2 comments
Labels
app:CowSwap CowSwap app wontfix Stale issue

Comments

@nenadV91
Copy link
Contributor

nenadV91 commented Mar 31, 2022

We want to pass the slippage tolerance value as an order parameter to the API's and/or also to the Sentry.

Screenshot from 2022-03-31 10-43-00.png

@nenadV91 nenadV91 added the app:CowSwap CowSwap app label Mar 31, 2022
@anxolin
Copy link
Contributor

anxolin commented Mar 31, 2022

Coordinate with backend, the initial Idea:

  • When we get the quote, backend will send an ID that identififies the quote. This id helps them to debug and we should include it in the posting of the order
  • Include slippage in the post i.e in bips? or '0.5' (to agree with backend)
  • [good to have] Ideally include this information in the metadata (IPFS)

@stale
Copy link

stale bot commented Jun 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app wontfix Stale issue
Projects
None yet
Development

No branches or pull requests

2 participants