332/instantiating cow sdk #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
W3stside
reviewed
May 30, 2022
W3stside
approved these changes
Jun 2, 2022
anxolin
reviewed
Jun 7, 2022
| @@ -7,6 +7,9 @@ import { SupportedChainId as ChainId } from 'constants/chains' | |||
| import { getAppDataHash } from './appDataHash' | |||
| import ms from 'ms.macro' | |||
|
|
|||
| import { CowSdk } from '@cowprotocol/cow-sdk' | |||
| import { PINATA_API_KEY, PINATA_SECRET_API_KEY } from 'constants/ipfs' | |||
There was a problem hiding this comment.
I thought we were already having the pinata keys, since we were already uploading the doc to IPFS fo the affiliate program
There was a problem hiding this comment.
Yes, we do have them.
They are just being imported here
| [ChainId.MAINNET]: new CowSdk(ChainId.MAINNET, COW_SDK_OPTIONS), | ||
| [ChainId.RINKEBY]: new CowSdk(ChainId.RINKEBY, COW_SDK_OPTIONS), | ||
| [ChainId.GNOSIS_CHAIN]: new CowSdk(ChainId.GNOSIS_CHAIN, COW_SDK_OPTIONS), | ||
| } |
There was a problem hiding this comment.
I guess this "instance" per network will be changed in the future so we only need one, right?
There was a problem hiding this comment.
Yes, to be handled on cowprotocol/cow-sdk#30
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #332
Adding SDK instances
To Test
Nothing to test