Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain Id and Prod/Barn environments improvements #30

Closed
ramirotw opened this issue Jun 2, 2022 · 2 comments · Fixed by #42
Closed

Chain Id and Prod/Barn environments improvements #30

ramirotw opened this issue Jun 2, 2022 · 2 comments · Fixed by #42
Assignees

Comments

@ramirotw
Copy link
Contributor

ramirotw commented Jun 2, 2022

  1. Make chain id optional in the constructor and default to mainnet
  2. Add an optional options param on each API method where we can set the chainId and the env (prod/barn)
  3. The API methods should query both prod & barn environments so we abstract them away from the user
@anxolin
Copy link
Contributor

anxolin commented Jun 3, 2022

Great to see these changes. I would just add that we should have a way to change the initial defaults from the constructor

This way, we hav two ways of using the SDK

  • Always providing the options
  • ..or, dapps can change the default network when this one changes

@ramirotw
Copy link
Contributor Author

3. The API methods should query both prod & barn environments so we abstract them away from the user

@matextrem lets pause the env merging so we can discuss about the pagination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants