332/quote id on metadata

[alfetopito]

Summary

Part of #332

Passing down quoteId received from quote call, if any

Note: There will be a follow up PR removing quoteId and sell|buyAmount from metadata in favor of slippageBips (see cowprotocol/cow-sdk#41)

To Test

1. Fill in trade data (or do nothing, as it'll pre-fill with WETH-USDC pair)
2. Observe the console logs. Filter by appData

• It should contain id inside the quote object
  

3. Write down the quote id
   
4. Switch to the network tab
5. Place an order and open it on the browser https://barn.api.cow.fi/mainnet/api/v1/orders/<orderId>

• Check the appDataHash in the order matches the last console debug log

6. On the network tab, check for the POST request where the order was placed. Check the request sub tab

• It should contain the field quoteId matching the id noted on step 3
  

7. Back at the console tab, filter the console log for UploadToIpfs

• Check the appData related to your order has been uploaded, like the image

8. Search for the appDataHash using https://codepen.io/pacara/pen/BadZgjg?editors=0101

• Check it exists and the fields match the last console debug log

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

• 🔭 GP Swap: CoW Protocol v2 Swap UI

[elena-zh]

Hey @alfetopito ,
I have noticed that sometimes appdata logs do not contain ID. It happens when a token pair is selected for the 1st time, and 2 logs appear: 1st without ID, the 2nd contains it. . Related to all networks. Is it OK?

Then, I have found a request in the Netowkr tab with the same ID, but the appData does not match there. See:

It is in Rinkeby. I the screenshots you provided above the appdata matches. The issue is also related to GC and Ethereum networks

[elena-zh]

I have also noticed that there is no 'Fees exceed from amount' message in your PR

[alfetopito]

I have also noticed that there is no 'Fees exceed from amount' message in your PR

I'll address that in this PR #748, still not fixed

[alfetopito]

Hey @alfetopito , I have noticed that sometimes appdata logs do not contain ID. It happens when a token pair is selected for the 1st time, and 2 logs appear: 1st without ID, the 2nd contains it. . Related to all networks. Is it OK?

Then, I have found a request in the Netowkr tab with the same ID, but the appData does not match there. See:

It is in Rinkeby. I the screenshots you provided above the appdata matches. The issue is also related to GC and Ethereum networks

Regarding the quoteId issues, 2 comments:

The next PR is removing it from the metadata, so I'd ask you to ignore the issues here as it won't be there anymore.
Maybe it makes more sense to skip the test here and verify the issues solved or not there.