Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

332/refactor use address #748

Merged
merged 5 commits into from
Jul 1, 2022
Merged

332/refactor use address #748

merged 5 commits into from
Jul 1, 2022

Conversation

alfetopito
Copy link
Collaborator

Summary

Follow up to this comment #647 (comment)

To Test

  1. Test regular affiliate flow
  • Should work like before

@alfetopito alfetopito self-assigned this Jun 24, 2022
@alfetopito alfetopito requested a review from anxolin June 24, 2022 16:23
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@alfetopito alfetopito mentioned this pull request Jun 24, 2022
Merged
W3stside
W3stside approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh elena-zh mentioned this pull request Jun 27, 2022
Merged
@elena-zh
Copy link

Originally reported in #747 (review)

Once I opened the PR preview link, I started seeing an affiliate program message. However, I had not shared a referral link . Moreover, when I stitched to Mainnet, 'invalid referral code' message started to be displayed.
Could you please take a look at this issue?
no referral
reff
affiliate

@alfetopito
Copy link
Collaborator Author

Originally reported in #747 (review)

Once I opened the PR preview link, I started seeing an affiliate program message. However, I had not shared a referral link . Moreover, when I stitched to Mainnet, 'invalid referral code' message started to be displayed. Could you please take a look at this issue? no referral reff affiliate

Thanks!

Can you check again now? (after the build completes)

@elena-zh
Copy link

@alfetopito , I still see this message when I open the app link for the 1st time
image

anxolin
anxolin approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addresing

@alfetopito alfetopito force-pushed the 332/generate-appDataHash-for-every-order branch from 42ecff3 to e625664 Compare June 29, 2022 11:04
@alfetopito alfetopito mentioned this pull request Jun 29, 2022
Merged
@alfetopito alfetopito force-pushed the 332/refactor-useAddress branch from 3ddd965 to 370cbeb Compare June 30, 2022 16:38
@alfetopito alfetopito force-pushed the 332/refactor-useAddress branch from 370cbeb to 139d317 Compare July 1, 2022 10:08
@alfetopito
Copy link
Collaborator Author

@alfetopito , I still see this message when I open the app link for the 1st time image

It was (another) silly mistake.

Should be all good now! ™️ (famous last words)

@alfetopito
Copy link
Collaborator Author

Elena, I'm merging this to the parent PR to consolidate.
I think it makes sense for you to test it all there instead #629

I can always create a new PR if there still something to be addressed

@alfetopito alfetopito merged commit 64cb1e1 into 332/generate-appDataHash-for-every-order Jul 1, 2022
@alfetopito alfetopito deleted the 332/refactor-useAddress branch July 1, 2022 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@W3stside W3stside W3stside approved these changes

@anxolin anxolin anxolin approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfetopito @elena-zh @anxolin @W3stside