322/store quote info on redux

[alfetopito]

Summary

Part of #332

Making both sell and buy amounts returned with the quote available in redux context

These amounts will later be stored in the order metadata to calculate real surplus (difference between quote prices and executed prices)

To Test

1. Using redux developer addon/extension, load the page
2. Go to redux > actions > State
   
3. Filter by price
4. Click on a price/refreshQuote action
5. In the tree navigation, open price -> quotes -> 1 -> <token address> -> price
   

• You should see the field oppositeAmount populated
• There should be no changes at all to the behaviour

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

• 🔭 GP Swap: CoW Protocol v2 Swap UI

[elena-zh]

Hey @alfetopito , I can't see 'oppositeAmount' for 'refreshQuote' request, but I can see it for 'rupdateQuote' in Mainnet and GC.
Is it intentional that it is missing for Rinkeby?

Also, I see duplicating requests, and one of them does not contain opposite amount. Is it OK?

[alfetopito]

Hey @alfetopito , I can't see 'oppositeAmount' for 'refreshQuote' request, but I can see it for 'rupdateQuote' in Mainnet and GC. Is it intentional that it is missing for Rinkeby?

Also, I see duplicating requests, and one of them does not contain opposite amount. Is it OK?

You are looking at the diff. This is the redux state management and it only updates a field when it changes.
Check the state instead and it'll be there.

[elena-zh]

@alfetopito , thanks for explanation!
LGTM!

[W3stside]

don't really understand why we need the oppositeAmount. also the issue linked is the wrong one i believe, code looks ok tho!

[alfetopito]

don't really understand why we need the oppositeAmount.

We will need to add to the metadata of every order both sell and buy amounts returned in the quote response.

Right now, only one of those (buy or sell, depending on the order type) is stored.
This change adds the opposite amount (if sell, store the buy, if buy, store the sell).

As said, aware this is not the best name, happy to hear suggestions :)

also the issue linked is the wrong one i believe

You are right, wrong issue id 🤦 . Correct one -> #332

[anxolin]

Maybe i did sth wrong but id didn't get the "opposite" field

[anxolin]

i find oppositeAmount missliading.

If we can really not add from/to, would it be better amountInputted or something?

[anxolin]

What I mentioned yesterday is.

Why do we need to change the quote object here?

Maybe we can avoid modifying it. We already have the state of the original inputed amount from the user in our state. We just need to include that in the quote object of the meta-data of the order when we submit the order.

This metadata could have normal names as suggested in the document (no backward compatibility issues, because is a new metadata)

[alfetopito]

As Anxo points out, the information needed (sell and buy amounts) are already in the context.

https://github.com/cowprotocol/cowswap/blob/1a7b9d4928240d195b40feacbf870eac8c2deda0/src/custom/hooks/useSwapCallback.ts#L156-L157=

Namely inputAmountWithFee and experectedOutputAmount.

Thus this change is unnecessary.

When there's a quoteId coming from the backend though, I'll send a new PR, but likely will have to come from the sdk instead.
See #561 and #567