Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review: Using ibc-go (cosmos/interchain-security) #71

Closed
1 task done
mpoke opened this issue Apr 26, 2022 · 2 comments
Closed
1 task done

Code review: Using ibc-go (cosmos/interchain-security) #71

mpoke opened this issue Apr 26, 2022 · 2 comments
Assignees
@AdityaSripal
Labels
scope: testing Code review, testing, making sure the code is following the specification.
Milestone
ICS v1.0.0

Comments

@mpoke
Copy link
Contributor

mpoke commented Apr 26, 2022 •
edited
Loading

  • ibc-go team needs to review the code from an IBC perspective
@mpoke mpoke added the scope: testing Code review, testing, making sure the code is following the specification. label Apr 26, 2022
@danwt
Copy link
Contributor

danwt commented Sep 1, 2022

Ditto comment about closing criteria for issues (see #70 (comment))

@mpoke mpoke moved this from Todo to In Progress in Replicated Security Dec 20, 2022
@mpoke mpoke added this to Cosmos Hub Jan 17, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jan 17, 2023
@mpoke mpoke added this to the ICS v1.0.0 milestone Jan 17, 2023
@mpoke mpoke moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Jan 17, 2023
@mpoke mpoke moved this from 🏗 In progress to ✅ Done in Cosmos Hub Feb 23, 2023
@mpoke
Copy link
Contributor Author

mpoke commented Feb 23, 2023

Outcome of code review:

@mpoke mpoke closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaSripal AdityaSripal

Labels
scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
ICS v1.0.0
Development

No branches or pull requests
3 participants
@AdityaSripal @mpoke @danwt