Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutOfBlockGas handling #726

Closed
AdityaSripal opened this issue Feb 8, 2023 · 2 comments
Closed

OutOfBlockGas handling #726

AdityaSripal opened this issue Feb 8, 2023 · 2 comments
Assignees
Labels
source: audit To indicate an issue found during an audit. type: feature-request New feature or request improvement

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Feb 8, 2023

The new CCV modules introduces a lot of logic to be handled in the BeginBlock and Endblock. This could end up consuming a large amount of the block gas limit which may leave no space for transactions or even worse, the beginblock/endblock alone may consume all the gas in the block which I believe will cause a panic and crash the chain

I think there should be some stress testing with many consumer chains to see how much a provider chain can comfortably handle.

If the per-block logic is indeed very expensive relative to the block gas limit, then we need to prioritize making optimizations and even queueing the logic so that not everything must run in the block but can be dequeued as the remaining block gas allows.

@AdityaSripal AdityaSripal added the source: audit To indicate an issue found during an audit. label Feb 8, 2023
@mpoke mpoke added this to Cosmos Hub Feb 23, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Feb 23, 2023
@mpoke mpoke added this to the ICS v1.1.0 milestone Feb 23, 2023
@mpoke mpoke added the type: feature-request New feature or request improvement label Mar 5, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Mar 5, 2023
@mpoke mpoke removed this from the ICS v1.1.0 milestone Mar 5, 2023
@mpoke
Copy link
Contributor

mpoke commented Mar 13, 2023

@AdityaSripal do BeginBlock and EndBlock consume the block gas limit?

@mpoke mpoke self-assigned this Mar 13, 2023
@mpoke mpoke moved this from 📥 Todo to 🏗 In progress in Cosmos Hub Mar 21, 2023
@mpoke mpoke moved this from 🏗 In progress to 🛑 Blocked in Cosmos Hub Apr 12, 2023
@AdityaSripal
Copy link
Member Author

Turns out they do not, closing issue as hitting gas limit is no longer a risk

@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in Cosmos Hub Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: audit To indicate an issue found during an audit. type: feature-request New feature or request improvement
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants