Should we check ChannelToChain on AcknowledgePacket

[AdityaSripal]

ChannelToChain mapping is checked on TimeoutPacket but not on AcknowledgePacket

interchain-security/x/ccv/provider/keeper/relay.go

Line 141 in 463ec20

chainID, found := k.GetChannelToChain(ctx, packet.SourceChannel)

interchain-security/x/ccv/provider/keeper/relay.go

Line 120 in 463ec20

func (k Keeper) OnAcknowledgementPacket(ctx sdk.Context, packet channeltypes.Packet, ack channeltypes.Acknowledgement) error {

Not sure if there is a reason for the difference

[insumity]

Synced (offline) with @AdityaSripal and we can close this ticket.

The reason being that k.GetChannelToChain is actually called by both OnTimeoutPacket and OnAcknowledgementPacket. Note that k.GetChannelToChain is used in a similar fashion by both methods. In OnTimeoutPacket we know something went wrong due to the timeout and we get the chain with k.GetChannelToChain, if we find the chain we stop it. Similarly, in OnAcknowledgementPacket if there's an error in the acknowledgement, we get the chain through k.GetChannelToChain and if we find the chain we stop it.