Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nits from Audit #719

Closed
AdityaSripal opened this issue Feb 7, 2023 · 0 comments · Fixed by #743
Closed

Nits from Audit #719

AdityaSripal opened this issue Feb 7, 2023 · 0 comments · Fixed by #743
Labels
source: audit To indicate an issue found during an audit.
Milestone
ICS v1.0.1

Comments

@AdityaSripal
Copy link
Member

interchain-security/x/ccv/provider/keeper/proposal.go

Line 63 in 463ec20

// Consumers always start out with the default unbonding period

Comment incorrect?

Version checked twice in OnChanOpen Init:

https://github.com/cosmos/interchain-security/blob/main/x/ccv/consumer/ibc_module.go#L42

https://github.com/cosmos/interchain-security/blob/main/x/ccv/consumer/ibc_module.go#L53

Should be returning empty string version if the error is non-nil in OnChanOpenInit:

https://github.com/cosmos/interchain-security/blob/main/x/ccv/consumer/ibc_module.go#L24
@AdityaSripal AdityaSripal added the source: audit To indicate an issue found during an audit. label Feb 7, 2023
@mpoke mpoke mentioned this issue Feb 23, 2023
Closed
1 task
@mpoke mpoke added this to Cosmos Hub Feb 23, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Feb 23, 2023
@mpoke mpoke added this to the ICS v1.0.1 milestone Feb 23, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Feb 23, 2023
@shaspitz shaspitz mentioned this issue Feb 24, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Cosmos Hub Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
source: audit To indicate an issue found during an audit.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
ICS v1.0.1
Development

Successfully merging a pull request may close this issue.

Fix nits from audit cosmos/interchain-security
2 participants
@AdityaSripal @mpoke