Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height <-> ValsetUpdateID mapping is inefficient #718

Closed
Tracked by #1087
AdityaSripal opened this issue Feb 7, 2023 · 2 comments
Closed
Tracked by #1087

Height <-> ValsetUpdateID mapping is inefficient #718

AdityaSripal opened this issue Feb 7, 2023 · 2 comments
Labels
S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability source: audit To indicate an issue found during an audit. type: feature-request New feature or request improvement type: tech-debt Slows down development in the long run

Comments

@AdityaSripal
Copy link
Member

At the moment, we save a mapping to valset updateID at every height. This is a new key added every block even if the valset hasn't changed.

We can instead only store the mapping on the height at which the valset is updated.

We can still recover the relevant valsetUpdateID for a given infraction height by using iterators.

Not necessary for first release perhaps, but this is a clear optimization that may prove necessary later on

@AdityaSripal AdityaSripal added source: audit To indicate an issue found during an audit. type: feature-request New feature or request improvement iterators labels Feb 7, 2023
@mpoke mpoke added this to Cosmos Hub Feb 23, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Feb 23, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Feb 23, 2023
@mpoke mpoke added this to the ICS v1.1.0 milestone Feb 23, 2023
@mpoke mpoke modified the milestones: ICS v1.1.0, ICS next release Mar 5, 2023
@mpoke mpoke added the type: tech-debt Slows down development in the long run label Jun 20, 2023
@mpoke mpoke removed this from the ICS next release milestone Jun 20, 2023
@mpoke mpoke added the S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability label Sep 13, 2023
@mpoke mpoke moved this from 📥 F2: Todo to 🛑 F3: OnHold in Cosmos Hub Sep 13, 2023
@mpoke
Copy link
Contributor

mpoke commented Sep 13, 2023

Putting this issue on hold as epochs would solve the problem.

@mpoke mpoke moved this from 🛑 F3: OnHold to 📥 F2: Todo in Cosmos Hub Sep 14, 2023
@mpoke mpoke removed the iterators label Mar 22, 2024
@mpoke
Copy link
Contributor

mpoke commented Apr 11, 2024

Solved by the introduction of epochs.

@mpoke mpoke closed this as completed Apr 11, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Apr 11, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability source: audit To indicate an issue found during an audit. type: feature-request New feature or request improvement type: tech-debt Slows down development in the long run
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants