ccvTimeoutTimestamp param

[jtremback]

It should be moved into the tests/ folder to reduce the size of the main codebase and reduce potential confusion.

[mpoke]

It is also used here

interchain-security/x/ccv/utils/utils.go

Line 79 in 5e3ff16

clienttypes.Height{}, uint64(ccv.GetTimeoutTimestamp(ctx.BlockTime()).UnixNano()),

[jtremback]

Very good point. Must have missed that. It is used on every send.

Still, I would make a few changes.

types/utils.go should not be its own file. The function is so short that it should just be done inline where it is used.
const TimeDelay = 4 * 7 * 24 * time.Hour should not be a magic number any more. It should be put into a param called IBCTimeoutTimestamp. This will need to be passed into SendIBCPacket because it's not a function on the keeper struct and does not have access to the params stuff.

[mpoke]

It should be put into a param called IBCTimeoutTimestamp.

For consistency, I'd use the names from the spec, i.e., ccvTimeoutTimestamp. We need to differentiate it from the transfer timeout timestamp, i.e., transferTimeoutTimestamp, see

interchain-security/x/ccv/consumer/keeper/distribution.go

Line 17 in b6aff82

const TransferTimeDelay = 1 * 7 * 24 * time.Hour // 1 weeks