#533 throttle normal operation diff testing PR rebase #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
December 6, 2022 11:23
commit b28e176 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Mon Dec 5 17:11:41 2022 -0800 requested key format changes (#560) changes commit 5b8d2c7 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Mon Dec 5 13:12:55 2022 -0800 log
commit 01b13d3 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Thu Dec 8 18:34:49 2022 -0800 weird commit a759c07 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Thu Dec 8 13:33:34 2022 -0800 Throttle bug fixes + req refactors (#565) * fixes * Update throttle.go * fix tests * set replenish frac = 1.0 for all test runs * rm unmarshal func * req refactors * small lint fix * comment adjustment * found <-> jailed order swap * 100% change
danwt
requested review from
jtremback,
mpoke,
sainoe and
shaspitz
as code owners
|
Closed in favor of #580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the diff tests core model to tests scenarios where the throttle
fraction=1.0and the throttle is replenished every block.This should allow all slashes to occur as per the spec as if the throttle didn't exist. This is a good baseline to get into the testnet and main until the full spec can be flesh out and more throttle scenarios can be tested (#534)
Issue