Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#533 throttle normal operation diff testing PR #571

Closed
wants to merge 18 commits into from

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Dec 8, 2022

Adjusts the diff tests core model to tests scenarios where the throttle fraction=1.0 and the throttle is replenished every block.

	prams.SlashMeterReplenishFraction = "1.0"
	prams.SlashMeterReplenishPeriod = time.Second * 1

This should allow all slashes to occur as per the spec as if the throttle didn't exist. This is a good baseline to get into the testnet and main until the full spec can be flesh out and more throttle scenarios can be tested (#534)

Issue

@danwt danwt changed the title Danwt/circuit breaker diff test mvp #533 throttle normal operation diff testing PR Dec 8, 2022
@danwt danwt marked this pull request as ready for review December 9, 2022 07:06
commit 01b13d3
Author: Shawn Marshall-Spitzbart <[email protected]>
Date:   Thu Dec 8 18:34:49 2022 -0800

    weird

commit a759c07
Author: Shawn Marshall-Spitzbart <[email protected]>
Date:   Thu Dec 8 13:33:34 2022 -0800

    Throttle bug fixes + req refactors (#565)

    * fixes

    * Update throttle.go

    * fix tests

    * set replenish frac = 1.0 for all test runs

    * rm unmarshal func

    * req refactors

    * small lint fix

    * comment adjustment

    * found <-> jailed order swap

    * 100% change
@danwt
Copy link
Contributor Author

danwt commented Dec 9, 2022

closed in favor of #579

@danwt danwt closed this Dec 9, 2022
@danwt danwt deleted the danwt/circuit-breaker-diff-test-MVP branch December 9, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant