Adds some goc-december logging #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 9, 2022 11:08
danwt
requested review from
jtremback,
mpoke,
sainoe and
shaspitz
as code owners
shaspitz
reviewed
Dec 9, 2022
| // TODO: refactor this out test (-v) verbose flag needed to see output! | ||
| func ProviderAppIniterWithLog() (ibctesting.TestingApp, map[string]json.RawMessage) { | ||
| l := log.TestingLogger() | ||
| l = log.NewFilter(l, |
There was a problem hiding this comment.
The log has a feature where you add filter k/v pairs, and only lines includes those pairs are shown. By doing this, and specifying module", "x/ibc-provider it filters out all the sdk logging (during tests only!)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MVP for improved logging intended for goc-december. Further polish will be needed before adapting the contents of this PR for main/
Partially tackles
The difftest change let me test out the log statements by using the diff test execution paths but with the actual testing part disabled.