feat: explicit config file entry for ABCI client type #20080
Conversation
Co-authored-by: likhita-809 <[email protected]> Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: emidev98 <[email protected]> Co-authored-by: colin axnér <[email protected]> Co-authored-by: Marko Baricevic <[email protected]> Co-authored-by: likhita-809 <[email protected]> Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: emidev98 <[email protected]> Co-authored-by: colin axnér <[email protected]> Co-authored-by: Marko Baricevic <[email protected]>
* chore: bump tendermint to `0.34.22` * update changelog * update changelog * go mod tidy all
…s when rewards are zero (cosmos#13588)
…tConfig. (cosmos#13610) * Populate the PruningKeepEvery config entry in GetConfig. * Update changlog.
* docs: add ApplicationQueryService release notes * updates Co-authored-by: Julien Robert <[email protected]>
…os#13612) (cosmos#13616) * feat(cli): add module-account cli cmd and grpc get api (cosmos#13612) (cherry picked from commit ddf5cf0) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # x/auth/client/testutil/suite.go # x/auth/types/query.pb.go * fix conflicts * updates * updates Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…#12474) (cosmos#13598) * fix(x/auth): allow multiple = signs in `GetTxsEvent` (cosmos#12474) (cherry picked from commit 18da0e9) # Conflicts: # CHANGELOG.md * fix changelog * changelog * fix: flakey test Co-authored-by: Tyler <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…os#13612) (cosmos#13617) * feat(cli): add module-account cli cmd and grpc get api (cosmos#13612) (cherry picked from commit ddf5cf0) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # proto/cosmos/auth/v1beta1/query.proto # tests/e2e/auth/suite.go # x/auth/client/cli/query.go # x/auth/keeper/grpc_query.go # x/auth/keeper/grpc_query_test.go # x/auth/types/query.pb.go # x/auth/types/query.pb.gw.go * update changelog * fix conflicts Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Julien Robert <[email protected]>
* chore: prepare 0.45.10 changelog * default release notes * period
…cosmos#13656) (cosmos#13659) (cherry picked from commit c833190) Co-authored-by: William Chong <[email protected]>
…smos#13656) (cosmos#13660) * feat(cli): Add iavl-disable-fastnode cmd flag with proper description (cosmos#13656) (cherry picked from commit c833190) # Conflicts: # server/start.go * fix conflicts Co-authored-by: William Chong <[email protected]> Co-authored-by: Julien Robert <[email protected]>
* chore: prepare 0.46.4 changelog * wording * updates * updates
* ci: notify for 0.45.x releases * update changelog
* feat: notify for 0.46.x releases * updates changelog
* ci: modifying docs in 0.46 should not redeploy docs * updates
…osmos#13804) * refactor: add error log when iavl set failed (cosmos#13803) * add error log when iavl set failed Ref: cosmos#12012 * Update CHANGELOG.md * play safe (cherry picked from commit 22f3261) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: yihuang <[email protected]>
* chore: prepare 0.45.11 release * no features in 0.45.11 * Update RELEASE_NOTES.md Co-authored-by: Aleksandr Bezobchuk <[email protected]> * update release notes Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Setting the flag still works and takes precedence.
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:Keys
WalkthroughWalkthroughThis update primarily focuses on upgrading the Go language version from 1.18 to 1.19 across various GitHub workflows and Docker configurations. It also involves updates to linter settings, modifications in automation rules for merging and releasing, and enhancements in documentation and configuration files to align with the new version. Notably, there's a shift in linter tools and an introduction of structured changelogs and branch management guides for the Agoric project. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (48)
Files selected for processing (21)
Files skipped from review due to trivial changes (1)
Additional Context UsedLanguageTool (245)
Additional comments not posted (52)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
C:x/bank
C:x/params
C:x/crisis
C:x/auth
C:x/evidence
C:x/upgrade
C:x/feegrant
C:x/genutil
|
Wrong repo. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -149,7 +149,7 @@ Pull requests that fix bugs and add features that fall in the following categori | |||
| As rule of thumb, the following changes will **NOT** be automatically accepted into stable point-releases: | |||
|
|
|||
| * **State machine changes**. | |||
| * **Protobug-breaking changes**, as specified in [ADR-044](./docs/architecture/adr-044-protobuf-updates- guidelines.md). | |||
| * **Protobug-breaking changes**, as specified in [ADR-044](https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-044-protobuf-updates- guidelines.md). | |||
There was a problem hiding this comment.
Clarify Protobuf updates guidelines link.
- [ADR-044](https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-044-protobuf-updates- guidelines.md)
+ [ADR-044](https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-044-protobuf-updates-guidelines.md)The URL to the ADR-044 document contains unnecessary spaces, which could lead to a broken link. Correcting this ensures the link is accessible.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * **Protobug-breaking changes**, as specified in [ADR-044](https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-044-protobuf-updates- guidelines.md). | |
| * **Protobug-breaking changes**, as specified in [ADR-044](https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-044-protobuf-updates-guidelines.md). |
| To improve clarity of the API, some renaming and improvements has been done: | ||
|
|
There was a problem hiding this comment.
Consider revising the grammar in the sentence for better clarity.
- To improve clarity of the API, some renaming and improvements has been done:
+ To improve the clarity of the API, some renaming and improvements have been made:Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| To improve clarity of the API, some renaming and improvements has been done: | |
| To improve the clarity of the API, some renaming and improvements have been made: |
| #### new packages | ||
|
|
||
| Additionally, new packages have been introduced in order to further split the codebase. Aliases are available for a new API breaking migration, but it is encouraged to migrate to this new packages: | ||
|
|
||
| * `errors` should replace `types/errors` when registering errors or wrapping SDK errors. | ||
| * `math` contains the `Int` or `Uint` types that are used in the SDK. | ||
|
|
There was a problem hiding this comment.
Capitalize the first letter of bullet points for consistency.
- * `errors` should replace `types/errors` when registering errors or wrapping SDK errors.
- * `math` contains the `Int` or `Uint` types that are used in the SDK.
+ * `Errors` should replace `types/errors` when registering errors or wrapping SDK errors.
+ * `Math` contains the `Int` or `Uint` types that are used in the SDK.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #### new packages | |
| Additionally, new packages have been introduced in order to further split the codebase. Aliases are available for a new API breaking migration, but it is encouraged to migrate to this new packages: | |
| * `errors` should replace `types/errors` when registering errors or wrapping SDK errors. | |
| * `math` contains the `Int` or `Uint` types that are used in the SDK. | |
| #### new packages | |
| Additionally, new packages have been introduced in order to further split the codebase. Aliases are available for a new API breaking migration, but it is encouraged to migrate to this new packages: | |
| * `Errors` should replace `types/errors` when registering errors or wrapping SDK errors. | |
| * `Math` contains the `Int` or `Uint` types that are used in the SDK. | |
| The keyring has been refactored in v0.46. | ||
|
|
||
| * The `Unsafe*` interfaces have been removed from the keyring package. Please use interface casting if you wish to access those unsafe functions. | ||
| * The keys' implementation has been refactored to be serialized as proto. | ||
| * `keyring.NewInMemory` and `keyring.New` takes now a `codec.Codec`. | ||
| * Take `keyring.Record` instead of `Info` as first argument in: | ||
| * `MkConsKeyOutput` | ||
| * `MkValKeyOutput` | ||
| * `MkAccKeyOutput` | ||
| * Rename: | ||
| * `SavePubKey` to `SaveOfflineKey` and remove the `algo` argument. | ||
| * `NewMultiInfo`, `NewLedgerInfo` to `NewLegacyMultiInfo`, `newLegacyLedgerInfo` respectively. | ||
| * `NewOfflineInfo` to `newLegacyOfflineInfo` and move it to `migration_test.go`. | ||
|
|
There was a problem hiding this comment.
Tip
Codebase Verification
The verification process has revealed the following:
- The removal of
Unsafe*interfaces from the keyring package does not affect other parts of the codebase. The occurrences of "Unsafe" in the codebase are unrelated to the keyring package and are part of different functionalities or configurations. - There is no evidence of the correct usage of the new
keyring.New($_, $_)method in the codebase. This suggests that the new API might not be integrated properly or at all.
Based on these findings, the following actions are recommended:
- Ensure that the new
keyring.Newmethod is integrated and used correctly throughout the codebase.
Analysis chain
Review the changes in the keyring API for potential breaking changes.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that the removed `Unsafe*` interfaces are not used elsewhere in the codebase.
rg --type go "Unsafe"
# Check for correct usage of the new keyring API.
ast-grep --lang go --pattern $'keyring.New($_, $_)'
Length of output: 13503
| * The `x/param` module has been depreacted in favour of each module housing and providing way to modify their parameters. Each module that has parameters that are changable during runtime have an authority, the authority can be a module or user account. The Cosmos-SDK team recommends migrating modules away from using the param module. An example of how this could look like can be found [here](https://github.com/cosmos/cosmos-sdk/pull/12363). | ||
| * The Param module will be maintained until April 18, 2023. At this point the module will reach end of life and be removed from the Cosmos SDK. | ||
|
|
There was a problem hiding this comment.
Correct the spelling mistake and add a comma for clarity.
- * The `x/param` module has been depreacted in favour of each module housing and providing way to modify their parameters.
+ * The `x/param` module has been deprecated in favor of each module housing and providing a way to modify their parameters.
- * The Param module will be maintained until April 18, 2023. At this point the module will reach end of life and be removed from the Cosmos SDK.
+ * The Param module will be maintained until April 18, 2023. At this point, the module will reach end of life and be removed from the Cosmos SDK.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * The `x/param` module has been depreacted in favour of each module housing and providing way to modify their parameters. Each module that has parameters that are changable during runtime have an authority, the authority can be a module or user account. The Cosmos-SDK team recommends migrating modules away from using the param module. An example of how this could look like can be found [here](https://github.com/cosmos/cosmos-sdk/pull/12363). | |
| * The Param module will be maintained until April 18, 2023. At this point the module will reach end of life and be removed from the Cosmos SDK. | |
| * The `x/param` module has been deprecated in favor of each module housing and providing a way to modify their parameters. Each module that has parameters that are changable during runtime have an authority, the authority can be a module or user account. The Cosmos-SDK team recommends migrating modules away from using the param module. An example of how this could look like can be found [here](https://github.com/cosmos/cosmos-sdk/pull/12363). | |
| * The Param module will be maintained until April 18, 2023. At this point, the module will reach end of life and be removed from the Cosmos SDK. |
| - `Agoric` - the trunk for our cosmos-sdk fork, used by [agoric-sdk](https://github.com/Agoric/agoric-sdk). | ||
| - New features which we plan to use in a near-future release are added here. | ||
| - Most releases are tagged here. | ||
| - `Agoric-vX.Y.Z-alpha.agoric.A.x` - a lazily-created release branch. | ||
| - Branched off of release tag `vX.Y.Z-alpha.agoric.A`. | ||
| - Created when we need a new release that omits some changes present on trunk. | ||
| - Prefer to contain only cherry-picks from trunk. | ||
| - Pattern can be extended to sub-sub-branches should the need arise. | ||
|
|
||
| Tag convention: | ||
|
|
||
| - `vX.Y.Z-alpha.agoric.A` for tagged releases on the `Agoric` branch: | ||
| - `vX.Y.Z` is the version of the latest integrated cosmos/cosmos-sdk release. | ||
| - The `A` is an increasing sequence resetting to `1` after the integration of a new cosmos/cosmos-sdk release. | ||
| - `vX.Y.Z-alpha.agoric.A.B` for "patch" releases on branch `Agoric-vX.Y.Z-alpha.agoric.A.x`. | ||
| - `B` starts at 1 and increases sequentially. | ||
| - Pattern can be extended to releases on sub-sub-branches should the need arise. | ||
|
|
||
| For new features: | ||
|
|
||
| - New features should be landed on `Agoric` first, then cherry-picked to a release branch as needed. | ||
| - Create a new development branch off of `Agoric`. | ||
| - Test, review, merge PR with `automerge` label for mergify.io | ||
| - Don't forget to update `CHANGELOG-Agoric.md` with the change and a link to its PR. | ||
|
|
||
| Upon new cosmos-sdk releases, see [upgrading the Interchain Stack](https://github.com/Agoric/agoric-sdk/wiki/Upgrading-the-Interchain-Stack). | ||
|
|
||
| Historical work: | ||
| - [ag0](https://github.com/Agoric/ag0) [Agoric mainnet](https://agoric.com) | ||
| phase 0's [gaiad-equivalent](https://github.com/cosmos/gaia) | ||
| - `Agoric-ag0` - should be identical to | ||
| [cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) + changes needed by | ||
| `ag0` |
There was a problem hiding this comment.
Correct spelling mistakes and grammatical errors to enhance the clarity and professionalism of the document.
- lazily-created
+ lazily created
- Branched off of
+ Branched from
- vX.Y.Z-alpha.agoric.A.x
+ vX.Y.Z-alpha.agoric.A.xCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - `Agoric` - the trunk for our cosmos-sdk fork, used by [agoric-sdk](https://github.com/Agoric/agoric-sdk). | |
| - New features which we plan to use in a near-future release are added here. | |
| - Most releases are tagged here. | |
| - `Agoric-vX.Y.Z-alpha.agoric.A.x` - a lazily-created release branch. | |
| - Branched off of release tag `vX.Y.Z-alpha.agoric.A`. | |
| - Created when we need a new release that omits some changes present on trunk. | |
| - Prefer to contain only cherry-picks from trunk. | |
| - Pattern can be extended to sub-sub-branches should the need arise. | |
| Tag convention: | |
| - `vX.Y.Z-alpha.agoric.A` for tagged releases on the `Agoric` branch: | |
| - `vX.Y.Z` is the version of the latest integrated cosmos/cosmos-sdk release. | |
| - The `A` is an increasing sequence resetting to `1` after the integration of a new cosmos/cosmos-sdk release. | |
| - `vX.Y.Z-alpha.agoric.A.B` for "patch" releases on branch `Agoric-vX.Y.Z-alpha.agoric.A.x`. | |
| - `B` starts at 1 and increases sequentially. | |
| - Pattern can be extended to releases on sub-sub-branches should the need arise. | |
| For new features: | |
| - New features should be landed on `Agoric` first, then cherry-picked to a release branch as needed. | |
| - Create a new development branch off of `Agoric`. | |
| - Test, review, merge PR with `automerge` label for mergify.io | |
| - Don't forget to update `CHANGELOG-Agoric.md` with the change and a link to its PR. | |
| Upon new cosmos-sdk releases, see [upgrading the Interchain Stack](https://github.com/Agoric/agoric-sdk/wiki/Upgrading-the-Interchain-Stack). | |
| Historical work: | |
| - [ag0](https://github.com/Agoric/ag0) [Agoric mainnet](https://agoric.com) | |
| phase 0's [gaiad-equivalent](https://github.com/cosmos/gaia) | |
| - `Agoric-ag0` - should be identical to | |
| [cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) + changes needed by | |
| `ag0` | |
| - `Agoric` - the trunk for our cosmos-sdk fork, used by [agoric-sdk](https://github.com/Agoric/agoric-sdk). | |
| - New features which we plan to use in a near-future release are added here. | |
| - Most releases are tagged here. | |
| - `Agoric-vX.Y.Z-alpha.agoric.A.x` - a lazily created release branch. | |
| - Branched from release tag `vX.Y.Z-alpha.agoric.A`. | |
| - Created when we need a new release that omits some changes present on trunk. | |
| - Prefer to contain only cherry-picks from trunk. | |
| - Pattern can be extended to sub-sub-branches should the need arise. | |
| Tag convention: | |
| - `vX.Y.Z-alpha.agoric.A` for tagged releases on the `Agoric` branch: | |
| - `vX.Y.Z` is the version of the latest integrated cosmos/cosmos-sdk release. | |
| - The `A` is an increasing sequence resetting to `1` after the integration of a new cosmos/cosmos-sdk release. | |
| - `vX.Y.Z-alpha.agoric.A.B` for "patch" releases on branch `Agoric-vX.Y.Z-alpha.agoric.A.x`. | |
| - `B` starts at 1 and increases sequentially. | |
| - Pattern can be extended to releases on sub-sub-branches should the need arise. | |
| For new features: | |
| - New features should be landed on `Agoric` first, then cherry-picked to a release branch as needed. | |
| - Create a new development branch off of `Agoric`. | |
| - Test, review, merge PR with `automerge` label for mergify.io | |
| - Don't forget to update `CHANGELOG-Agoric.md` with the change and a link to its PR. | |
| Upon new cosmos-sdk releases, see [upgrading the Interchain Stack](https://github.com/Agoric/agoric-sdk/wiki/Upgrading-the-Interchain-Stack). | |
| Historical work: | |
| - [ag0](https://github.com/Agoric/ag0) [Agoric mainnet](https://agoric.com) | |
| phase 0's [gaiad-equivalent](https://github.com/cosmos/gaia) | |
| - `Agoric-ag0` - should be identical to | |
| [cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) + changes needed by | |
| `ag0` |
| - New features which we plan to use in a near-future release are added here. | ||
| - Most releases are tagged here. | ||
| - `Agoric-vX.Y.Z-alpha.agoric.A.x` - a lazily-created release branch. | ||
| - Branched off of release tag `vX.Y.Z-alpha.agoric.A`. | ||
| - Created when we need a new release that omits some changes present on trunk. | ||
| - Prefer to contain only cherry-picks from trunk. |
There was a problem hiding this comment.
Adjust the indentation of unordered list items for consistency and readability.
- - New features which we plan to use in a near-future release are added here.
+ - New features which we plan to use in a near-future release are added here.
- - Most releases are tagged here.
+ - Most releases are tagged here.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - New features which we plan to use in a near-future release are added here. | |
| - Most releases are tagged here. | |
| - `Agoric-vX.Y.Z-alpha.agoric.A.x` - a lazily-created release branch. | |
| - Branched off of release tag `vX.Y.Z-alpha.agoric.A`. | |
| - Created when we need a new release that omits some changes present on trunk. | |
| - Prefer to contain only cherry-picks from trunk. | |
| - New features which we plan to use in a near-future release are added here. | |
| - Most releases are tagged here. | |
| - `Agoric-vX.Y.Z-alpha.agoric.A.x` - a lazily-created release branch. | |
| - Branched off of release tag `vX.Y.Z-alpha.agoric.A`. | |
| - Created when we need a new release that omits some changes present on trunk. | |
| - Prefer to contain only cherry-picks from trunk. |
Description
Refs: Agoric/agoric-sdk#9224
Add an explicit entry for
abci-client-typein the TOML file. The setting can be done in the file but is overridden by when the command-line flag is set.Note that this entry is unlike the other entries in the "base config" part of the TOML file, in that there are no
BaseApp.Get/SetABCIClientType()methods, option helpers, etc. This makes it more like the various start command flags that do not have explicit config fields, e.g.--with-tendermintor--trace-store. This seems appropriate for a setting that is used near the "top" of the start command.Note that even without this change, the option can be set in the
config/app.tomlfile. This just makes the entry part of the automatically-generated TOML file.Note that the default value is now specified both in the flag definition and in the default config constructor, as some of the other flags are. It's confusing to think about which one takes precedence, so they should just be kept in sync.
Tested the following:
app.tomlapp.tomlentry and override with a different legal valueAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
actions/labelerto resolve issues..mergify.yml..gitignoreto exclude new directories and files.