Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs refactor #415

Merged
merged 27 commits into from
Feb 13, 2018
Merged

Docs refactor #415

merged 27 commits into from
Feb 13, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Feb 3, 2018 •
edited
Loading

@zramsay zramsay requested a review from jaekwon as a code owner February 3, 2018 00:12
@zramsay zramsay mentioned this pull request Feb 6, 2018
Closed
@zramsay zramsay changed the title WIP: Docs refactor Docs refactor Feb 7, 2018
@zramsay
Copy link
Contributor Author

zramsay commented Feb 7, 2018

http://cosmos-sdk.readthedocs.io/en/docs-refactor/

^ while not complete, the documentation is in a presentable state, ready to iterate upon.

@zramsay zramsay changed the base branch from consolidate to develop February 8, 2018 13:51
@zramsay zramsay changed the base branch from develop to consolidate February 8, 2018 13:51
@jbibla
Copy link
Contributor

jbibla commented Feb 12, 2018

@zramsay failing on CI?

@zramsay zramsay changed the base branch from consolidate to develop February 12, 2018 18:59
@zramsay zramsay closed this Feb 12, 2018
@zramsay zramsay reopened this Feb 12, 2018
@zramsay zramsay requested a review from ebuchman as a code owner February 13, 2018 14:11
@codecov
Copy link

codecov bot commented Feb 13, 2018 •
edited
Loading

Codecov Report

Merging #415 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #415   +/-   ##
========================================
  Coverage    52.18%   52.18%           
========================================
  Files           35       35           
  Lines         1671     1671           
========================================
  Hits           872      872           
  Misses         742      742           
  Partials        57       57

ebuchman
ebuchman reviewed Feb 13, 2018
View reviewed changes
docs/design.md
@@ -1,96 +0,0 @@
## Design Document
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this go ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in the body of sdk/overview.rst, see http://cosmos-sdk.readthedocs.io/en/docs-refactor/sdk/overview.html

@ebuchman
Copy link
Member

Not sure what to do with this PR.

I rebased it on develop, threw away the early/unneeded commits from frey/adrian, and re-removed attic. But it seems the design document has been lost and the docs are all mixed up between new sdk and old. For instance any mention of sdk.Actor is old sdk ...

Please clean this up and make a new PR. Let's please not mix old and new docs so we know clearly which docs are up to date and which need updating

@ebuchman ebuchman closed this Feb 13, 2018
@ebuchman ebuchman reopened this Feb 13, 2018
@ebuchman
Copy link
Member

Ok my bad. Seems like this ok after all. Still a WIP #336 (comment)

@ebuchman ebuchman merged commit 51dca8f into develop Feb 13, 2018
@ebuchman ebuchman deleted the docs-refactor branch February 13, 2018 14:30
@coderabbitai coderabbitai bot mentioned this pull request Apr 18, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman ebuchman left review comments

@jaekwon jaekwon Awaiting requested review from jaekwon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zramsay @jbibla @ebuchman