fix: avoid cli redundant log in stdout #19371
Conversation
|
Warning Rate Limit Exceeded@mmsqe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 59 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe changes focus on refining logging practices within a specific module, transitioning from using standard output to standard error for logging purposes. This adjustment is aimed at enhancing error handling and messaging, particularly in the context of migration processes, by ensuring that migration errors and success messages are more accurately directed, thereby improving the overall clarity and effectiveness of the logging system. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: .coderabbit.yml
Commits
Files that changed from the base of the PR and between 4b8f326 and 67fed2d85d0e800dd8f9d63abe609f2031d1d5a1.Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- crypto/keyring/keyring.go (2 hunks)
Additional comments: 2
crypto/keyring/keyring.go (2)
- 919-919: Directing migration error messages to
os.Stderraligns with the PR's objective to avoid cluttering stdout. This change is appropriate for the context.- 993-993: Directing the success message for key migration to
os.Stderris consistent with the PR's goal and improves the usability of CLI tools by keeping stdout clean for machine-readable output.
mmsqe
changed the title
log to stderr instead
julienrbrt
added
the
backport/v0.50.x
(cherry picked from commit 863194f) # Conflicts: # CHANGELOG.md
fix: avoid cli redundant log in stdout (cosmos#19371)
log to stderr instead
Description
Closes: #19368
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit