Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basecoin-name handler example #337

Closed
1 task
jbibla opened this issue Jan 17, 2018 · 2 comments
Closed
1 task

basecoin-name handler example #337

jbibla opened this issue Jan 17, 2018 · 2 comments
Assignees
Milestone

Comments

@jbibla
Copy link
Contributor

jbibla commented Jan 17, 2018

needed from @jaekwon ...

  • written spec of each error type and how to use them
  • should all errors be in global errors package or should each extension have their own errors?
@jaekwon jaekwon mentioned this issue Jan 17, 2018
16 tasks
@jbibla jbibla added this to the SDK2 milestone Jan 17, 2018
@jaekwon
Copy link
Contributor

jaekwon commented Jan 29, 2018

I think the way errors are used now is good enough ATM, and we'll have to see how people deal with their error needs. I think the best thing would be to copy x/bank/errors.go, and I think anyone who wants to create their own modules will see that...

Maybe what's missing is an example module for basecoin, e.g. a handler to change the name of a user. And there, in the module dir for the basecoin-name handler, will be errors.go which includes documentation that says, this is how you do it.

@jaekwon
Copy link
Contributor

jaekwon commented Jan 29, 2018

Otherwise, currently the @deveop branch does use errors correctly (it's all been recently fixed). So it's good enough for making an announcement, but lets leave this open to finish the basecoin-name handler example above.

@rigelrozanski rigelrozanski changed the title handle errors properly basecoin-name handler example Jan 30, 2018
@jbibla jbibla closed this as completed Jan 30, 2018
catShaark referenced this issue in notional-labs/cosmos-sdk Nov 5, 2022
* module export implementation

* part 2

* change order

* add modulesToExport instead of blank string

(cherry picked from commit 6849de6)

Co-authored-by: Adam Tucker <[email protected]>
gibson042 pushed a commit to gibson042/cosmos-sdk that referenced this issue Apr 12, 2024
…)" (cosmos#337)

* Revert "fix: halt-height behavior is not deterministic (cosmos#305)"

This reverts commit 7b8423a.

This commit caused test failures in agoric-sdk.
Reverting to land other changes in agoric-sdk.
We'll restore the change and try to debug the failure
against a smaller diff in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants