-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basecoin-name handler example #337
Comments
I think the way errors are used now is good enough ATM, and we'll have to see how people deal with their error needs. I think the best thing would be to copy x/bank/errors.go, and I think anyone who wants to create their own modules will see that... Maybe what's missing is an example module for basecoin, e.g. a handler to change the name of a user. And there, in the module dir for the basecoin-name handler, will be errors.go which includes documentation that says, this is how you do it. |
Otherwise, currently the @deveop branch does use errors correctly (it's all been recently fixed). So it's good enough for making an announcement, but lets leave this open to finish the basecoin-name handler example above. |
* module export implementation * part 2 * change order * add modulesToExport instead of blank string (cherry picked from commit 6849de6) Co-authored-by: Adam Tucker <[email protected]>
…)" (cosmos#337) * Revert "fix: halt-height behavior is not deterministic (cosmos#305)" This reverts commit 7b8423a. This commit caused test failures in agoric-sdk. Reverting to land other changes in agoric-sdk. We'll restore the change and try to debug the failure against a smaller diff in the future.
needed from @jaekwon ...
The text was updated successfully, but these errors were encountered: