-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single or multiple binaries #379
Comments
i'm in favour of the least amount of binaries; this makes documentation much easier to write/update; the code easier to dive into, and the release process smoother |
I absolutely agree with Jae on logically splitting those three binaries into:
However I don't think that we should split the Gaia from the Tendermint binary. The Gaia Full Node Daemon should just run Tendermint in-process. Reasons This way the cli/ui doesn't have to care what the user is running underneath. The cli/ui talks to an HSM through a socket that it connects too. This way the daemon's don't have to deal with user key management (one of the biggest annoyances for Parity/Geth in my opinion). Usability
After that the installation is |
Yeah, should be in-process. |
How does it making documentation easier to write or update? It's just replacing It makes code harder to dive into because you need to first dive into a mega-binary. It would be easier if there were less irrelevant subcommands in the binary implementation you're looking for. The release process, ok. We could release a zip and a signed txt file holding all the shasums of each item in the zip. It's not that much more complicated. Am I missing something? |
More reasons: In general, in the case of the cli, we want to make it as small a binary as possible since we're talking about potentially very resource constrained devices. The tendermint binary itself is clocking in at 2.4MB, but I don't think the cli needs to be that large. In general, we don't know what dependencies we'll require for the full node vs the light node proxy. It'll be nice to maintain that separation such that we can introduce dependencies that aren't needed in a light node proxy. We might make the Tendermint binary fairly large, say 20MB or more. The light client could still stay tiny. |
alright i'm convinced. multiple binaries makes sense |
Let's go with Currently the |
) * Revert "feat: remove bank multisend msg (cosmos#274)" This reverts commit 9165099. * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates
fix: avoid cli redundant log in stdout (cosmos#19371)
The question is, should we ship one binary (
gaia
) as we currently do or multiple binaries? It would be nice if this issue could serve as a final decision and documentation on that matter.Quotes:
Jae:
Frey:
The text was updated successfully, but these errors were encountered: