feat: remove bank multisend msg (cosmos#274)

* in progress * in progress * remove all code * remove old error code comments * edit comment * removed Input and Output proto structs * Delete deprecated comment Co-authored-by: mattverse <[email protected]>
patiee · Jul 1, 2022 · 9165099 · 9165099
1 parent d0da4b4
commit 9165099
Show file tree

Hide file tree

Showing 23 changed files with 70 additions and 2,242 deletions.
diff --git a/codec/types/interface_registry.go b/codec/types/interface_registry.go
@@ -43,7 +43,7 @@ type InterfaceRegistry interface {
 	// the interface iface.
 	//
 	// Ex:
-	//  registry.RegisterImplementations((*sdk.Msg)(nil), &MsgSend{}, &MsgMultiSend{})
+	//  registry.RegisterImplementations((*sdk.Msg)(nil), &MsgSend{})
 	RegisterImplementations(iface interface{}, impls ...proto.Message)
 
 	// ListAllInterfaces list the type URLs of all registered interfaces.

diff --git a/docs/core/proto-docs.md b/docs/core/proto-docs.md
@@ -79,9 +79,7 @@
 
 - [cosmos/bank/v1beta1/bank.proto](#cosmos/bank/v1beta1/bank.proto)
     - [DenomUnit](#cosmos.bank.v1beta1.DenomUnit)
-    - [Input](#cosmos.bank.v1beta1.Input)
     - [Metadata](#cosmos.bank.v1beta1.Metadata)
-    - [Output](#cosmos.bank.v1beta1.Output)
     - [Params](#cosmos.bank.v1beta1.Params)
     - [SendEnabled](#cosmos.bank.v1beta1.SendEnabled)
     - [Supply](#cosmos.bank.v1beta1.Supply)
@@ -116,8 +114,6 @@
     - [Query](#cosmos.bank.v1beta1.Query)
 
 - [cosmos/bank/v1beta1/tx.proto](#cosmos/bank/v1beta1/tx.proto)
-    - [MsgMultiSend](#cosmos.bank.v1beta1.MsgMultiSend)
-    - [MsgMultiSendResponse](#cosmos.bank.v1beta1.MsgMultiSendResponse)
     - [MsgSend](#cosmos.bank.v1beta1.MsgSend)
     - [MsgSendResponse](#cosmos.bank.v1beta1.MsgSendResponse)
 
@@ -1588,22 +1584,6 @@ denomination unit of the basic token.
 
 
 
-<a name="cosmos.bank.v1beta1.Input"></a>
-
-### Input
-Input models transaction input.
-
-
-| Field | Type | Label | Description |
-| ----- | ---- | ----- | ----------- |
-| `address` | [string](#string) |  |  |
-| `coins` | [cosmos.base.v1beta1.Coin](#cosmos.base.v1beta1.Coin) | repeated |  |
-
-
-
-
-
-
 <a name="cosmos.bank.v1beta1.Metadata"></a>
 
 ### Metadata
@@ -1629,22 +1609,6 @@ Since: cosmos-sdk 0.43 |
 
 
 
-<a name="cosmos.bank.v1beta1.Output"></a>
-
-### Output
-Output models transaction outputs.
-
-
-| Field | Type | Label | Description |
-| ----- | ---- | ----- | ----------- |
-| `address` | [string](#string) |  |  |
-| `coins` | [cosmos.base.v1beta1.Coin](#cosmos.base.v1beta1.Coin) | repeated |  |
-
-
-
-
-
-
 <a name="cosmos.bank.v1beta1.Params"></a>
 
 ### Params
@@ -2131,32 +2095,6 @@ Query defines the gRPC querier service.
 
 
 
-<a name="cosmos.bank.v1beta1.MsgMultiSend"></a>
-
-### MsgMultiSend
-MsgMultiSend represents an arbitrary multi-in, multi-out send message.
-
-
-| Field | Type | Label | Description |
-| ----- | ---- | ----- | ----------- |
-| `inputs` | [Input](#cosmos.bank.v1beta1.Input) | repeated |  |
-| `outputs` | [Output](#cosmos.bank.v1beta1.Output) | repeated |  |
-
-
-
-
-
-
-<a name="cosmos.bank.v1beta1.MsgMultiSendResponse"></a>
-
-### MsgMultiSendResponse
-MsgMultiSendResponse defines the Msg/MultiSend response type.
-
-
-
-
-
-
 <a name="cosmos.bank.v1beta1.MsgSend"></a>
 
 ### MsgSend
@@ -2198,7 +2136,6 @@ Msg defines the bank Msg service.
 | Method Name | Request Type | Response Type | Description | HTTP Verb | Endpoint |
 | ----------- | ------------ | ------------- | ------------| ------- | -------- |
 | `Send` | [MsgSend](#cosmos.bank.v1beta1.MsgSend) | [MsgSendResponse](#cosmos.bank.v1beta1.MsgSendResponse) | Send defines a method for sending coins from one account to another account. | |
-| `MultiSend` | [MsgMultiSend](#cosmos.bank.v1beta1.MsgMultiSend) | [MsgMultiSendResponse](#cosmos.bank.v1beta1.MsgMultiSendResponse) | MultiSend defines a method for sending coins from some accounts to other accounts. | |
 
  <!-- end services -->
 

diff --git a/proto/cosmos/bank/v1beta1/bank.proto b/proto/cosmos/bank/v1beta1/bank.proto
@@ -23,26 +23,6 @@ message SendEnabled {
   bool   enabled                      = 2;
 }
 
-// Input models transaction input.
-message Input {
-  option (gogoproto.equal)           = false;
-  option (gogoproto.goproto_getters) = false;
-
-  string   address                        = 1;
-  repeated cosmos.base.v1beta1.Coin coins = 2
-      [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"];
-}
-
-// Output models transaction outputs.
-message Output {
-  option (gogoproto.equal)           = false;
-  option (gogoproto.goproto_getters) = false;
-
-  string   address                        = 1;
-  repeated cosmos.base.v1beta1.Coin coins = 2
-      [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"];
-}
-
 // Supply represents a struct that passively keeps track of the total supply
 // amounts in the network.
 // This message is deprecated now that supply is indexed by denom.

diff --git a/proto/cosmos/bank/v1beta1/tx.proto b/proto/cosmos/bank/v1beta1/tx.proto
@@ -11,9 +11,6 @@ option go_package = "github.com/cosmos/cosmos-sdk/x/bank/types";
 service Msg {
   // Send defines a method for sending coins from one account to another account.
   rpc Send(MsgSend) returns (MsgSendResponse);
-
-  // MultiSend defines a method for sending coins from some accounts to other accounts.
-  rpc MultiSend(MsgMultiSend) returns (MsgMultiSendResponse);
 }
 
 // MsgSend represents a message to send coins from one account to another.
@@ -29,14 +26,3 @@ message MsgSend {
 
 // MsgSendResponse defines the Msg/Send response type.
 message MsgSendResponse {}
-
-// MsgMultiSend represents an arbitrary multi-in, multi-out send message.
-message MsgMultiSend {
-  option (gogoproto.equal) = false;
-
-  repeated Input  inputs  = 1 [(gogoproto.nullable) = false];
-  repeated Output outputs = 2 [(gogoproto.nullable) = false];
-}
-
-// MsgMultiSendResponse defines the Msg/MultiSend response type.
-message MsgMultiSendResponse {}
diff --git a/simapp/params/weights.go b/simapp/params/weights.go
@@ -3,7 +3,6 @@ package params
 // Default simulation operation weights for messages and gov proposals
 const (
 	DefaultWeightMsgSend                        int = 100
-	DefaultWeightMsgMultiSend                   int = 10
 	DefaultWeightMsgSetWithdrawAddress          int = 50
 	DefaultWeightMsgWithdrawDelegationReward    int = 50
 	DefaultWeightMsgWithdrawValidatorCommission int = 50

diff --git a/x/authz/keeper/keeper_test.go b/x/authz/keeper/keeper_test.go
@@ -13,6 +13,7 @@ import (
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/x/authz"
 	banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
+	govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
 )
 
 var bankSendAuthMsgType = banktypes.SendAuthorization{}.MsgTypeURL()
@@ -72,7 +73,7 @@ func (s *TestSuite) TestKeeper() {
 	s.Require().Equal(authorization.MsgTypeURL(), bankSendAuthMsgType)
 
 	s.T().Log("verify fetching authorization with wrong msg type fails")
-	authorization, _ = app.AuthzKeeper.GetCleanAuthorization(ctx, granteeAddr, granterAddr, sdk.MsgTypeURL(&banktypes.MsgMultiSend{}))
+	authorization, _ = app.AuthzKeeper.GetCleanAuthorization(ctx, granteeAddr, granterAddr, sdk.MsgTypeURL(&govtypes.MsgDeposit{}))
 	s.Require().Nil(authorization)
 
 	s.T().Log("verify fetching authorization with wrong grantee fails")