Merge pull request cosmos#379 from agoric-labs/mhofman/backport-19371

fix: avoid cli redundant log in stdout (cosmos#19371)
gibson042 · Feb 10, 2024 · f42d869 · f42d869
2 parents b0baff1 + 84d5de0
commit f42d869
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG-Agoric.md b/CHANGELOG-Agoric.md
@@ -39,6 +39,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 * Agoric/agoric-sdk#8871 Have `tx gov submit-proposal` accept either new or legacy syntax
 
+### Bug Fixes
+
+* (crypto) [#19371](https://github.com/cosmos/cosmos-sdk/pull/19371) Avoid cli redundant log in stdout, log to stderr instead.
+
 ## `v0.46.16-alpha.agoric.1` - 2024-02-05
 
 * Agoric/agoric-sdk#8224 Merge [cosmos/cosmos-sdk v0.46.16](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.16)

diff --git a/crypto/keyring/keyring.go b/crypto/keyring/keyring.go
@@ -856,7 +856,7 @@ func (ks keystore) MigrateAll() ([]*Record, error) {
 
 		rec, err := ks.migrate(key)
 		if err != nil {
-			fmt.Printf("migrate err for key %s: %q\n", key, err)
+			fmt.Fprintf(os.Stderr, "migrate err for key %s: %q\n", key, err)
 			continue
 		}
 
@@ -926,7 +926,7 @@ func (ks keystore) migrate(key string) (*Record, error) {
 		return nil, fmt.Errorf("unable to set keyring.Item, err: %w", err)
 	}
 
-	fmt.Printf("Successfully migrated key %s.\n", key)
+	fmt.Fprintf(os.Stderr, "Successfully migrated key %s.\n", key)
 
 	return k, nil
 }