Reuse x/upgrade validation functionality in cosmovisor #10464
Labels
Milestone
Comments
robert-zaremba
added
C:x/upgrade
C:Cosmovisor
|
Idea is to have 2 commands:
|
4 tasks
|
I split off #10718 as a blocker on this. Additionally, Cosmovisor currently uses the Cosmos-SDK v0.44.3 build, and this new plan validation is not yet part of that (or any released) build. So this |
Closed
19 tasks
|
Few weeks ago I created a PR and link SDK with the "top" one. I can update now to use the recently released beta |
19 tasks
mergify bot
pushed a commit
that referenced
this issue
Apr 7, 2022
## Description Needed for: #10464 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
In #10379 we added a x/upgrade plan validation CLI command. It's based on what's currently in cosmovisor.
Let's reduce the code in cosmovisor (as much as possible) and use the functionality from /x/upgrade.
For Admin Use
The text was updated successfully, but these errors were encountered: