refactor: make cosmovisor depend on x/upgrade only #14881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Cosmovisor
alexanderbez
approved these changes
Feb 2, 2023
|
Fixing the last tests.. |
JeancarloBarrios
approved these changes
Feb 2, 2023
julienrbrt
commented
Feb 2, 2023
| @@ -6,7 +6,7 @@ echo 'ERROR: UPGRADE "chain2" NEEDED at height: 49: zip_binary' | |||
|
|
|||
| # create upgrade info | |||
| # this info contains directly information about binaries (in chain2->chain3 update we test with info containing a link to the file with an address for the new chain binary) | |||
| echo '{"name":"chain2","height":49,"info":"{\"binaries\":{\"linux/amd64\":\"https://github.com/cosmos/cosmos-sdk/raw/main/tools/cosmovisor/testdata/repo/chain2-zip_bin/autod.zip?checksum=sha256:fd20f3163e5ab2ab430c0c2936de82fcf5f100a8497d7f121b9f34a1a4b96683\"}}"}' >$3 | |||
| echo '{"name":"chain2","height":49,"info":"{\"binaries\":{\"linux/amd64\":\"https://github.com/cosmos/cosmos-sdk/raw/main/tools/cosmovisor/testdata/repo/chain2-zip_bin/autod.zip?checksum=sha256:13767eb0b57bf51a0f43d49f6277d5df97d4dec672dc39822d23a82fb8e70a7b\"}}"}' >$3 | |||
There was a problem hiding this comment.
So, here I leave it to main, as it will pass as soon as this PR is merged. Otherwise, I need to select a commit, but I think it gets delete when this branch gets deleted.
I will verify here that everything goes well.
There was a problem hiding this comment.
Passed, as promised https://github.com/cosmos/cosmos-sdk/actions/runs/4079143992/jobs/7030203497 :D
19 tasks
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
4 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #10464
Closes: #9670, using
plan.DownloadUpgradevalidates the checksum as well.Note: because of all replaces, the GOSUMDB seems broken... I need to create a PR fixing that before 🙄
EDIT: Opened #14882
EDIT2: merged so all good now.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change