feat(x/upgrade): Add upgrade validation options and reuse upgrade functions in cosomovisor #11295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional if desired.
…required in there anymore.
…sum and add new tests for split out pieces.
…f for downloading and parsing.
…ry for cosmovisor.
# Conflicts: # cosmovisor/args.go # cosmovisor/args_test.go # cosmovisor/go.mod # cosmovisor/go.sum # x/upgrade/plan/info.go
# Conflicts: # cosmovisor/go.sum
dwedul-figure
commented
Mar 1, 2022
cosmovisor/go.mod
Outdated
Comment on lines
140
to
141
|
|
||
| replace github.com/cosmos/cosmos-sdk => ../. |
There was a problem hiding this comment.
This is the key change in this file. The rest of the changes are a result of this one.
Codecov Report
@@ Coverage Diff @@
## master #11295 +/- ##
==========================================
- Coverage 66.09% 65.07% -1.02%
==========================================
Files 715 689 -26
Lines 72876 71440 -1436
==========================================
- Hits 48165 46490 -1675
- Misses 21762 22253 +491
+ Partials 2949 2697 -252
|
dwedul-figure
changed the title
dwedul-figure
added
C:CLI
C:Cosmovisor
# Conflicts: # CHANGELOG.md # x/upgrade/client/cli/tx.go
# Conflicts: # CHANGELOG.md # cosmovisor/go.mod
# Conflicts: # CHANGELOG.md
|
Closing this since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #10464
Closes: #10718
This PR updates some of the
x/upgradevalidation to allow bypassing some checks. It also refactors cosmovisor to use some of the validation and functionality written in thex/upgrademodule.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change