-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Outgoing video stream is no longer working on iOS 13 and Xcode 11 beta #375
Comments
I just noticed that 13.1 beta was added just yesterday, so I'm going to rollback to 13.0 and check if it works there. |
Unfortunately, on iOS 13.0 the problem is remaining :( |
@EternallLight Some other user have not the same issue using iOS 13 Would you mind trying to use this simple test script (should with with a basic cordova init app) I will upgrade to iOS 13 in coming days and see if i can reproduce. |
Hi @hthetiot, I have tried the test script and had no positive results – both video frames are rendered as black squares. |
@EternallLight Thank you, I will upgrade one of my device to iOS 13. |
@EternallLight Are you using Xcode 11 ? Please provide exact version (currently I'm using XCode Version 10.3 - 10G8) |
@hthetiot, yes, it's Version 11.0 beta 6 (11M392r) |
@EternallLight XCode 11 beta 7 is available |
@hthetiot, wow, that must be fresh. I installed beta 6 on Thursday and it was the latest one. Got to upgrade, thanks. |
Thx @EternallLight will keep you posted on my discovery on my side. |
Added Xcode 11 on travis and task/ios-13 branch to start debugging. |
@EternallLight Can you see if you have proper hooks triggered on Xcode 11+ You should see something like that if it's triggered. Make sure to remove and add platform to trigger the hook.
|
I dont think cordova 7 or 8 support Xcode 11 I dont even think cordova 9 does support Xcode 11. See WIP #376 (comment) |
@hthetiot
After pushing the app to the device, I run your test. It asked Camera and Microphone permission as it is supposed to but still a black square was moving across the screen. |
By the way, not sure if it will be helpful, but there's another plugin in my project that was broken by breaking API changes in iOS 13: j3k0/cordova-plugin-openwith#67 |
I still think its Xcode 11 issue, would you mind trying Xcode 10+ and run on ios 13. |
@hthetiot I couldn't run it from Xcode 10 – it says that no support files for iOS 13 found. I'm gonna check if there's a way to fix this and push app to an iOS 13 device from 10th Xcode. |
Today, I've installed our production app from the AppStore on two devices with iOS 12.4 and 13.0, and tested – as expected, the outgoing video looks good on iOS 12.4, but there's a black view instead on iOS 13. I'm going to make a test build with the very latest version of the plugin and try it out on both devices now. |
Just rebuilt the app with the yesterday's Xcode which by the way is no longer beta. Unfortunately, no changes |
Sorry, my English is not good. 不好意思,我的英文不好 |
I confirm. |
Using SFSafariViewController is actually using safari's webrtc implementation. 用SFSafariViewController实际上用的是safari的webrtc实现 |
I understand. It sounds like a lot of work. For the current plugin users, fixing the issue within the plugin would be much more acceptable. |
Sorry moving fast @jesseer9 here master is 6.0.0: 5.0.5 been released: |
That is fast! Thanks @hthetiot ! My demo is using capacitor (and cocoapods) and having trouble compiling. Trying to figure if I need to bridge headers. Haven't had any luck finding documentation on mix and matching from both. Jessee |
@jesseer9
|
@hthetiot I'd be willing to take a stab, if I can find some documentation :) Jessee |
I will only close that issue aka #375 via master with https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/CHANGELOG.md#version-600 if @EternallLight @myhhx @cah-dunn @pethessa confirm it's fix iOS 13 and Xcode 11, I will close and release master (cd1a545) as 6.0.0 I will make an issue
|
@hthetiot I've been testing for about 3 days on iPad Pro, iPad Mini 4, and iPhone 11 Pro. The only difference is that I've been on Thanks again for all of the time and effort! |
@cah-dunn Done |
I plan to release 6.0.0 in next 72 hours but I need help to test iOS 13 on real device, I have only an iPhone 6 and iPad Mini 3 both not eligible to iOS 13, I would need confirmation that master is ok on iOS 13 on real device that would help me. If you need VP8 you can try #416 if you need Unified Plan test #407, I plan to merge this 2 on 6.0.0 potential depending the demand of the community. |
I've got iPhone 7 which is a little newer :) Will test the master branch once 6.0.0 is released |
Tested the latest master. iOS local video works fine, I can see it at both sides iOS & Chrome But, have an issue with remote video stream from Chrome - it's simply a black video element is displayed Our test case:
In Xcode logs I can see the following after enabled a video stream at Chrome side:
I think the issue relates to
Is there any advice re this ? |
@DaveLomber Try #416 see "Testing" section in the PR description.
What do you mean by "iOS local video works fine, I can see it at both sides iOS & Chrome" and "have an issue with remote video stream from Chrome " this is contradictory, do you even have a TURN server stup ? Please create dedicated issue, the this is getting out of topic. |
Thanks, I will try the mentioned branch
we do no force it, use default logic
OS X, 77 ver
We simply use:
I upgraded to the master branch cause we got an issue with iOS 13. |
@EternallLight did you had time to test iOS 13 ? |
@hthetiot Yes, I tested with the test script you provided on a clear Ionic app – it worked ok in both portrait and landscape modes. |
@DaveLomber ideal+min+max is not supported yet, see WIP #419
Will result in video: {min: 240, max: 240}, 240 do not match any available resolution on iOS. Try this first:
|
@EternallLight I do not have any issues with local iOS stream, it is displayed well, even with these constrains |
@DaveLomber Please create dedicated issue. I do not reproduce this issue. Also you are using MCU/SFU (jitsi) that can be the reason "Real" peer to peer do not have this problem. Also do you use TURN ?
Yes on master but currently fail on #419 prior update |
@EternallLight Can you fill a separate issue, the hook is supose to handle multiple extensions. |
I'm closing for now since @EternallLight said it's ok and he is the original reporter. PLEASE ONLY COMMENT if pure iOS 13 issue and you do Peer To Peer only (No MCU/SFU here see #416 for MCU/SFU janus/jisti and co.) |
@hthetiot I can confirm as well that a local video stream started working well under iOS 13 with the master branch Re constraints - I think either jitsi-lib or adapter.js converts it into supported format, so hence no issues with it at my side Re remote video stream is showing as black square - will file a separated issue Thank you 👍 |
@hthetiot |
@DaveLomber VP8 and VP9 support if you use jisti you do MCU/SFU make sure to mention it when you give feedback. (This PR with VP8 support was made for Janus support, will be merge soon) |
Hello,
I've just installed iOS 13.1 Beta on my iPhone and noticed that outgoing video is no longer working. After upgrading plugin to the latest version (previously used version is 4.0.2), the issue is still remaining. This does not seem to be a renderer issue, because I can see incoming video streams; the issues reproduces only for outgoing streams. A black square appears in place where should be my outgoing video view, and the other side cannot see my video, either.
Here is what's going on in logs when I enable the camera for an ongoing call:
No obvious error messages, but no video, either.
Could you please take a look?
Thanks,
Andrey.
The text was updated successfully, but these errors were encountered: