-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement M69 Native RTCPeerConnection.(addTrack|removeTrack) and sdpSemantics unified-plan support #407
Conversation
…nified-plan support
@cah-dunn if you may check this, I think you going to like/need it. |
ba3900f fix issue with RTCPeerConnection.addTrack|removeTrack. Swift Camera confirmed (RTCPeerConnection.removeTrack, RTCPeerConnection.addTrack, renegotiate Offer/Awnser) |
…ordova-rtc/cordova-plugin-iosrtc into task/libwebrtc-update-m69-unified-plan
@hthetiot Apologies, just saw your comment. I'll take a look today. |
Hi, Tried this branch with task/preferredCodec and it works well with iOS 12. We have specified Unified plan in our peer constraints. Thanks for your work. |
Hi, Is it possible to add replaceTrack as well in addition to addTrack/removeTrack? |
@akilude I will look into replaceTrack keep you posted. |
@akilude ReplaceTrack is too recent, I will need more work and possibly to update WebRTC for that. |
I understand @hthetiot , thanks for the update |
Using sdpSementics unified-plan is causing this error
On Chrome side:
On iOSRTC side:
This PR set SdpSemantics to UnifiedPlan by default and also handle PlanB.
To test
task/libwebrtc-update-m69-unified-plan
branch