-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/fix aspect ratio #418
Bug/fix aspect ratio #418
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
@menelike Can you for once in a issue or PR do not mix many topics in one. You have many thing right in your change here but the problem is because you talk about many topic instead of focusing your PR goal, you become more noisy than usefull here. Focus and do one thing at the time and create dedicated issues instead of talking about many things for nothing. I would really not like to work with you directly, you need to finish something before talking about another one. I will reply to your mixed topics but be aware next time, I will close and ignore your comment if you continue to mix topics and dont get more clean, you wasted a lot of my time with this kind of comments so fare. create dedicated issue for go fork else where
The hardest part in our industry is to finish what we start, You are not going to succeed if you dont focus. |
This comment was marked as off-topic.
This comment was marked as off-topic.
behavior of
https://www.w3.org/TR/mediacapture-streams/#media-track-constraints |
This PR fixes:
aspectRatio
(height is not set based on width and aspect ratio where 4/3 is the default aspect ratio)Todo
getConstrainRangeValues
needs to work well with bothInt64
andFloat32
(since aspectRatio is passed asNSNumber
=>Float32
)This has been tested in conjunction with #416 and #407 with
janus-gateway
as the backend, an iPhone XR with iOS 13.1.2 and ios-cordova 4.5.5 (downgraded manually) and H264 🚀