Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis build to use Xcode 11.0 (11A420a) and iOS 13 support #376

Merged
merged 15 commits into from
Oct 21, 2019

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Sep 2, 2019

No description provided.

@hthetiot hthetiot changed the title update travis build to use Xcode 11.0 (11M362v) update travis build to use Xcode 11.0 (11M362v) and iOS 13 support Sep 2, 2019
@hthetiot
Copy link
Contributor Author

hthetiot commented Sep 2, 2019

https://travis-ci.org/cordova-rtc/cordova-plugin-iosrtc/jobs/579741540#L1121

> cordova build ios
Cannot read property 'toLowerCase' of undefined
[ERROR] An error occurred while running subprocess cordova.
        
        cordova build ios exited with exit code 1.
        
        Re-running this command with the --verbose flag may provide more information.

Travis failed with XCode 11.

@hthetiot hthetiot added bug build and removed bug labels Sep 4, 2019
@hthetiot
Copy link
Contributor Author

hthetiot commented Sep 4, 2019

Cannot read property 'toLowerCase' of undefined
TypeError: Cannot read property 'toLowerCase' of undefined
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/lib/list-emulator-build-targets:54:45
    at Array.forEach (<anonymous>)
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/lib/list-emulator-build-targets:52:44
    at Array.reduce (<anonymous>)
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/lib/list-emulator-build-targets:50:57
    at Array.reduce (<anonymous>)
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/lib/list-emulator-build-targets:45:28
    at _fulfilled (/Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/node_modules/q/q.js:854:54)
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/node_modules/q/q.js:816:13)
[ERROR] An error occurred while running subprocess cordova.

@hthetiot hthetiot mentioned this pull request Sep 20, 2019
@hthetiot
Copy link
Contributor Author

Cannot read property 'toLowerCase' of undefined
TypeError: Cannot read property 'toLowerCase' of undefined
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/lib/list-emulator-build-targets:54:45
    at Array.forEach (<anonymous>)
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/lib/list-emulator-build-targets:52:44
    at Array.reduce (<anonymous>)
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/lib/list-emulator-build-targets:50:57
    at Array.reduce (<anonymous>)
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/lib/list-emulator-build-targets:45:28
    at _fulfilled (/Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/node_modules/q/q.js:854:54)
    at /Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/myApp/platforms/ios/cordova/node_modules/q/q.js:816:13)

related apache/cordova-ios#427
related meteor/meteor#10673

@hthetiot
Copy link
Contributor Author

related apache/cordova-ios#675

@hthetiot hthetiot changed the title update travis build to use Xcode 11.0 (11M362v) and iOS 13 support update travis build to use Xcode 11.0 (11A420a) and iOS 13 support Sep 27, 2019
@hthetiot hthetiot added this to the 5.0.4 milestone Sep 27, 2019
@hthetiot hthetiot self-assigned this Sep 27, 2019
@hthetiot
Copy link
Contributor Author

I will add Xcode 11 detection and if cordov-ios is bellow 5.0.1 possible display an message.

@hthetiot hthetiot modified the milestones: 5.0.4, 5.0.x, 5.1.x Oct 4, 2019
@hthetiot hthetiot removed this from the 5.1.x milestone Oct 7, 2019
@hthetiot hthetiot added this to the 5.0.5 milestone Oct 7, 2019
@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 9, 2019

Using new Hook and cordova-ios 5+, Bridging-Header.h is properly detected and updated once.

/*
 Licensed to the Apache Software Foundation (ASF) under one
 or more contributor license agreements.  See the NOTICE file
 distributed with this work for additional information
 regarding copyright ownership.  The ASF licenses this file
 to you under the Apache License, Version 2.0 (the
 "License"); you may not use this file except in compliance
 with the License.  You may obtain a copy of the License at
 http://www.apache.org/licenses/LICENSE-2.0
 Unless required by applicable law or agreed to in writing,
 software distributed under the License is distributed on an
 "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 */
//
//  Bridging-Header.h
//  __PROJECT_NAME__
//
//  Created by ___FULLUSERNAME___ on ___DATE___.
//  Copyright ___ORGANIZATIONNAME___ ___YEAR___. All rights reserved.
//
//
//  Use this file to import your target's public headers that you would like to expose to Swift.
//

#import <Cordova/CDV.h>

#import "cordova-plugin-iosrtc-Bridging-Header.h"

@hthetiot hthetiot modified the milestones: 5.0.5, 5.1.x Oct 15, 2019
@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 18, 2019

iosrtc-swift-support.js [INFO] cordova-plugin-iosrtc is checking issues in the generated project files:
iosrtc-swift-support.js [INFO] - Minimum "iOS Deployment Target" and "Deployment Target" to: "10.2"
iosrtc-swift-support.js [INFO] - "Runpath Search Paths" to: "@executable_path/Frameworks"
iosrtc-swift-support.js [INFO] - "Objective-C Bridging Header" to: "Cordova iOSRTC Sample/Plugins/cordova-plugin-iosrtc/cordova-plugin-iosrtc-Bridging-Header.h"
iosrtc-swift-support.js [INFO] - "ENABLE_BITCODE" set to: "NO"
iosrtc-swift-support.js [INFO] - "SWIFT_VERSION" set to: "4.2"
iosrtc-swift-support.js [INFO] ".pbxproj" project file found: ./platforms/ios/Cordova iOSRTC Sample.xcodeproj/project.pbxproj
iosrtc-swift-support.js [INFO] ".xcconfig" project file found: ./platforms/ios/cordova/build.xcconfig
iosrtc-swift-support.js [INFO] checking file: ./platforms/ios/cordova/build.xcconfig
iosrtc-swift-support.js [INFO] file is correct: ./platforms/ios/cordova/build.xcconfig
iosrtc-swift-support.js [INFO] checking file: ./platforms/ios/Cordova iOSRTC Sample.xcodeproj/project.pbxproj
iosrtc-swift-support.js [INFO] file is correct: ./platforms/ios/Cordova iOSRTC Sample.xcodeproj/project.pbxproj
Error: Cannot read property 'toLowerCase' of undefined

Using cordova-ios@4 may result in this issue, use cordova-ios 5+

cordova platform remove ios
cordova platform add ios@5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant