-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][REF] include representative address type in cooperator #363
Conversation
Codecov Report
@@ Coverage Diff @@
## 14.0 #363 +/- ##
==========================================
+ Coverage 47.59% 47.62% +0.02%
==========================================
Files 51 51
Lines 1914 1915 +1
Branches 352 352
==========================================
+ Hits 911 912 +1
Misses 952 952
Partials 51 51
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌 can you add the note about the conflicting representative fields like in 12.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌 can you add the note about the conflicting representative fields like in 12.0 ?
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
5afb5ac
to
11bfc83
Compare
This PR has the |
4f4d440
to
70c9d9d
Compare
Put the representative type in cooperator module instead of in partner_contact_address for inclusion in OCA.
70c9d9d
to
fe3e791
Compare
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at c8aeaf5. Thanks a lot for contributing to coopiteasy. ❤️ |
fix #350
related to coopiteasy/addons#262
12.0 version: #362