Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][REF] include representative address type in cooperator #362

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

victor-champonnois
Copy link
Member

@victor-champonnois victor-champonnois commented Sep 1, 2022

Fix #350
related to coopiteasy/addons#261
14.0 version: #363

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #362 (200944e) into 12.0 (918f1ab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             12.0     #362      +/-   ##
==========================================
+ Coverage   56.58%   56.59%   +0.01%     
==========================================
  Files          97       97              
  Lines        3524     3525       +1     
  Branches      560      560              
==========================================
+ Hits         1994     1995       +1     
  Misses       1451     1451              
  Partials       79       79              
Impacted Files Coverage Δ
cooperator/models/partner.py 64.91% <100.00%> (+0.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just check that deploying coopiteasy/addons#261 at the same time does not delete data in column type. I'm 90% sure it does not but worth a check.

@victor-champonnois victor-champonnois force-pushed the 12.0-add-representative-address-type branch from bdb209a to 59ef9a4 Compare September 2, 2022 09:25
@victor-champonnois
Copy link
Member Author

LGTM +1 Just check that deploying coopiteasy/addons#261 at the same time does not delete data in column type. I'm 90% sure it does not but worth a check.

I looked at the demain DB. I compared the prod with the test. There is exactly the same number of type "representative" and type "contact" in both DB, so there is no data loss (at least for this DB)

Put the representative type in cooperator module instead of in
partner_contact_address for inclusion in OCA.
@huguesdk huguesdk force-pushed the 12.0-add-representative-address-type branch 2 times, most recently from 2284c47 to caa9d59 Compare September 27, 2022 09:52
@huguesdk huguesdk changed the title 12.0 add representative address type [12.0][REF] include representative address type in cooperator Sep 27, 2022
@huguesdk
Copy link
Member

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-362-by-huguesdk-bump-minor, awaiting test results.

@github-grap-bot github-grap-bot merged commit 83ea6dc into 12.0 Sep 27, 2022
@github-grap-bot github-grap-bot deleted the 12.0-add-representative-address-type branch September 27, 2022 10:20
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at d326536. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate partner_contact_address to cooperator module
5 participants