-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][REF] include representative address type in cooperator #362
Conversation
Codecov Report
@@ Coverage Diff @@
## 12.0 #362 +/- ##
==========================================
+ Coverage 56.58% 56.59% +0.01%
==========================================
Files 97 97
Lines 3524 3525 +1
Branches 560 560
==========================================
+ Hits 1994 1995 +1
Misses 1451 1451
Partials 79 79
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just check that deploying coopiteasy/addons#261 at the same time does not delete data in column type
. I'm 90% sure it does not but worth a check.
bdb209a
to
59ef9a4
Compare
I looked at the demain DB. I compared the prod with the test. There is exactly the same number of type "representative" and type "contact" in both DB, so there is no data loss (at least for this DB) |
c447737
to
e5c98b3
Compare
Put the representative type in cooperator module instead of in partner_contact_address for inclusion in OCA.
2284c47
to
caa9d59
Compare
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at d326536. Thanks a lot for contributing to coopiteasy. ❤️ |
Fix #350
related to coopiteasy/addons#261
14.0 version: #363