Skip to content

Commit

Permalink
[REF] include representative address type in cooperator
Browse files Browse the repository at this point in the history
Put the representative type in cooperator module instead of in
partner_contact_address for inclusion in OCA.
  • Loading branch information
victor-champonnois authored and huguesdk committed Sep 27, 2022
1 parent 5db1d0c commit 70c9d9d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 0 additions & 1 deletion cooperator/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"product",
"partner_firstname",
"partner_contact_birthdate",
"partner_contact_address",
"partner_contact_gender",
"mail",
],
Expand Down
3 changes: 3 additions & 0 deletions cooperator/models/partner.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ def _compute_share_info(self):
store=True,
compute="_compute_representative_of_member_company",
)
# allows for representative to have their own address
# see https://github.com/coopiteasy/vertical-cooperative/issues/350
type = fields.Selection(selection_add=[("representative", "Representative")])
subscription_request_ids = fields.One2many(
"subscription.request", "partner_id", string="Subscription request"
)
Expand Down
5 changes: 5 additions & 0 deletions cooperator/readme/ROADMAP.rst
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
Gather and consolidate all cooperator settings in the application parameters.

Consider a refactoring for:
1. removing a potential redundancy between the boolean field "representative" and the address type "representative".
2. prevent new contacts to have the representative address type, if they are not representative.
See [this issue](https://github.com/coopiteasy/vertical-cooperative/issues/350)

0 comments on commit 70c9d9d

Please sign in to comment.