Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][REF] include representative address type in cooperator #363

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[14.0][REF] include representative address type in cooperator #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cooperator/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"product",
"partner_firstname",
"partner_contact_birthdate",
"partner_contact_address",
"partner_contact_gender",
"mail",
],
Expand Down
3 changes: 3 additions & 0 deletions cooperator/models/partner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ def _compute_share_info(self):
store=True,
compute="_compute_representative_of_member_company",
)
# allows for representative to have their own address
# see https://github.com/coopiteasy/vertical-cooperative/issues/350
type = fields.Selection(selection_add=[("representative", "Representative")])
subscription_request_ids = fields.One2many(
"subscription.request", "partner_id", string="Subscription request"
)
Expand Down
5 changes: 5 additions & 0 deletions cooperator/readme/ROADMAP.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
Gather and consolidate all cooperator settings in the application parameters.

Consider a refactoring for:
1. removing a potential redundancy between the boolean field "representative" and the address type "representative".
2. prevent new contacts to have the representative address type, if they are not representative.
See [this issue](https://github.com/coopiteasy/vertical-cooperative/issues/350)

known_caveats: the cooperator localization modules will have to be splitted in order to install the `cooperator` module without the `cooperator_website` module.