release-21.2: New SQL Activity page #72052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
New SQL Activity page that includes Sessions, Statement and Transaction pages. Partially addresses cockroachdb#66052 Release note (ui change): Session, Statement and Transaction pages are now grouped inside the new SQL Activity page.
Update ui-components version to include a fix on scrolling on pages with tooltip Release note: None
When the user clicks on a tab on the new SQL Activity page now the search params on the url is updated with the tab selection. This commit also create a common function to sync history so all the pages can use it and remove duplicate code. Release note: None
When a statement was not found, the return to statements link was returning to the SQL Activity page without the Statement tab selected. This commit adds the right tab to the return option. Release note: None
Previously, when changing tabs on SQL Activity page the history would be replaced, this commits change to push to history, meaning when the user clicks Back on the browser it will return for the previous tab. Release note: None
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
Release note (<category, see below>): <what> <show> <why>
matthewtodd
reviewed
Nov 2, 2021
There was a problem hiding this comment.
Checked out the branch to run locally,
Reviewable status:
complete! 1 of 0 LGTMs obtained
A recent commit changed the default value of filter to be an empty string, but we do have transactions that have no associated app names to it, so All and empty string should be treated as different cases. This commit reverse that changes and use All Release note (bug fix): Show All statements when filter All is selected and not only the ones with empty string
maryliag
deleted the
backport21.2-71175-71325-71522-71762-71845-71938
branch
This was referenced Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release
Release justification: Category 4