ui: use push instead of replace on browser history on SQL Activity page #71938
Conversation
Previously, when changing tabs on SQL Activity page the history would be replaced, this commits change to push to history, meaning when the user clicks Back on the browser it will return for the previous tab. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
|
bors r+ |
|
Build failed (retrying...): |
|
|
||
| const onTabChange = (tabId: string): void => { | ||
| setCurrentTab(tabId); | ||
| util.clearHistory(props.history); | ||
| util.syncHistory({ tab: tabId }, props.history); | ||
| props.history.location.search = ""; |
There was a problem hiding this comment.
hmm, history.location.search is already reset in line 83 in query.ts, do we need to reset that here as well ?
| util.clearHistory(props.history); | ||
| util.syncHistory({ tab: tabId }, props.history); | ||
| props.history.location.search = ""; | ||
| util.syncHistory({ tab: tabId }, props.history, true); |
There was a problem hiding this comment.
super minor nit: add a inline comment here for the boolean literal /* push */
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/db-console/src/views/sqlActivity/sqlActivityPage.tsx, line 30 at r1 (raw file):
Previously, Azhng (Archer Zhang) wrote…
hmm,
history.location.searchis already reset in line 83 inquery.ts, do we need to reset that here as well ?
yes, because the reset updates the current ones, but what I want is to remove all the query params before adding only the new tab selection
|
Build failed (retrying...): |
|
Build succeeded: |
Previously, when changing tabs on SQL Activity page the history
would be replaced, this commits change to push to history, meaning
when the user clicks Back on the browser it will return for the
previous tab.
Release note: None